Implement changes for account APIs (#715)

* Implement changes for account APIs

* Cleanup and re-add tests

* gofumpt

* Add availability notice

Author: zliang-akamai

account_settings.go

@@ -4,6 +4,15 @@ import (
 	"context"
 )
 
+type InterfacesForNewLinodes string
+
+const (
+	LegacyConfigOnly                    InterfacesForNewLinodes = "legacy_config_only"
+	LegacyConfigDefaultButLinodeAllowed InterfacesForNewLinodes = "legacy_config_default_but_linode_allowed"
+	LinodeDefaultButLegacyConfigAllowed InterfacesForNewLinodes = "linode_default_but_legacy_config_allowed"
+	LinodeOnly                          InterfacesForNewLinodes = "linode_only"
+)
+
 // AccountSettings are the account wide flags or plans that effect new resources
 type AccountSettings struct {
 	// The default backups enrollment status for all new Linodes for all users on the account.  When enabled, backups are mandatory per instance.
@@ -20,19 +29,23 @@ type AccountSettings struct {
 
 	// A string like "disabled", "suspended", or "active" describing the status of this account’s Object Storage service enrollment.
 	ObjectStorage *string `json:"object_storage"`
+
+	// NOTE: Interfaces for new linode setting may not currently be available to all users.
+	// A new configuration flag defines whether new Linodes can use Linode and/or legacy config interfaces.
+	InterfacesForNewLinodes InterfacesForNewLinodes `json:"interfaces_for_new_linodes"`
 }
 
 // AccountSettingsUpdateOptions are the updateable account wide flags or plans that effect new resources.
 type AccountSettingsUpdateOptions struct {
 	// The default backups enrollment status for all new Linodes for all users on the account.  When enabled, backups are mandatory per instance.
 	BackupsEnabled *bool `json:"backups_enabled,omitempty"`
 
-	// A plan name like "longview-3"..."longview-100", or a nil value for to cancel any existing subscription plan.
-	// Deprecated: Use PUT /longview/plan instead to update the LongviewSubscription
-	LongviewSubscription *string `json:"longview_subscription,omitempty"`
-
 	// The default network helper setting for all new Linodes and Linode Configs for all users on the account.
 	NetworkHelper *bool `json:"network_helper,omitempty"`
+
+	// NOTE: Interfaces for new linode setting may not currently be available to all users.
+	// A new configuration flag defines whether new Linodes can use Linode and/or legacy config interfaces.
+	InterfacesForNewLinodes *InterfacesForNewLinodes `json:"interfaces_for_new_linodes"`
 }
 
 // GetAccountSettings gets the account wide flags or plans that effect new resources

test/integration/account_settings_test.go

@@ -31,6 +31,10 @@ func TestAccountSettings_Get(t *testing.T) {
 	assert.Nil(t, accountSettings.LongviewSubscription, "Expected 'longview_subscription' to be nil")
 	assert.True(t, accountSettings.BackupsEnabled, "Expected 'backups_enabled' to be true")
 	assert.Equal(t, "active", *accountSettings.ObjectStorage, "Expected 'object_storage' to be 'active'")
+	assert.Equal(
+		t, linodego.LegacyConfigDefaultButLinodeAllowed, accountSettings.InterfacesForNewLinodes,
+		"Expected 'object_storage' to be 'active'",
+	)
 }
 
 func TestAccountSettings_Update(t *testing.T) {
@@ -41,9 +45,11 @@ func TestAccountSettings_Update(t *testing.T) {
 	base.SetUp(t)
 	defer base.TearDown(t)
 
+	i := linodego.LegacyConfigDefaultButLinodeAllowed
 	requestData := linodego.AccountSettingsUpdateOptions{
-		BackupsEnabled: Bool(true),
-		NetworkHelper:  Bool(true),
+		BackupsEnabled:          Bool(true),
+		NetworkHelper:           Bool(true),
+		InterfacesForNewLinodes: &i,
 	}
 	base.MockPut("account/settings", fixtureData)
 
@@ -55,4 +61,8 @@ func TestAccountSettings_Update(t *testing.T) {
 	assert.Nil(t, accountSettings.LongviewSubscription, "Expected 'longview_subscription' to be nil")
 	assert.True(t, accountSettings.BackupsEnabled, "Expected 'backups_enabled' to be true")
 	assert.Equal(t, "active", *accountSettings.ObjectStorage, "Expected 'object_storage' to be 'active'")
+	assert.Equal(
+		t, linodego.LegacyConfigDefaultButLinodeAllowed, accountSettings.InterfacesForNewLinodes,
+		"Expected 'object_storage' to be 'active'",
+	)
 }

test/integration/fixtures/TestAccountSettings.yaml

@@ -3,5 +3,6 @@
   "network_helper": true,
   "longview_subscription": null,
   "backups_enabled": true,
-  "object_storage": "active"
+  "object_storage": "active",
+  "interfaces_for_new_linodes": "legacy_config_default_but_linode_allowed"
 }

test/unit/account_settings_test.go

@@ -3,5 +3,6 @@
   "network_helper": true,
   "longview_subscription": null,
   "backups_enabled": true,
-  "object_storage": "active"
+  "object_storage": "active",
+  "interfaces_for_new_linodes": "legacy_config_default_but_linode_allowed"
 }