Change []*T to []T in all structs (#972)

Author: zliang-akamai

instance_ips.go

@@ -12,11 +12,11 @@ type InstanceIPAddressResponse struct {
 
 // InstanceIPv4Response contains the details of all IPv4 addresses associated with an Instance
 type InstanceIPv4Response struct {
-	Public   []*InstanceIP `json:"public"`
-	Private  []*InstanceIP `json:"private"`
-	Shared   []*InstanceIP `json:"shared"`
-	Reserved []*InstanceIP `json:"reserved"`
-	VPC      []*VPCIP      `json:"vpc"`
+	Public   []InstanceIP `json:"public"`
+	Private  []InstanceIP `json:"private"`
+	Shared   []InstanceIP `json:"shared"`
+	Reserved []InstanceIP `json:"reserved"`
+	VPC      []VPCIP      `json:"vpc"`
 }
 
 // InstanceIP represents an Instance IP with additional DNS and networking details

instance_snapshots.go

@@ -10,7 +10,7 @@ import (
 
 // InstanceBackupsResponse response struct for backup snapshot
 type InstanceBackupsResponse struct {
-	Automatic []*InstanceSnapshot             `json:"automatic"`
+	Automatic []InstanceSnapshot              `json:"automatic"`
 	Snapshot  *InstanceBackupSnapshotResponse `json:"snapshot"`
 }
 
@@ -32,16 +32,16 @@ type RestoreInstanceOptions struct {
 
 // InstanceSnapshot represents a linode backup snapshot
 type InstanceSnapshot struct {
-	ID        int                     `json:"id"`
-	Label     string                  `json:"label"`
-	Status    InstanceSnapshotStatus  `json:"status"`
-	Type      string                  `json:"type"`
-	Created   *time.Time              `json:"-"`
-	Updated   *time.Time              `json:"-"`
-	Finished  *time.Time              `json:"-"`
-	Configs   []string                `json:"configs"`
-	Disks     []*InstanceSnapshotDisk `json:"disks"`
-	Available bool                    `json:"available"`
+	ID        int                    `json:"id"`
+	Label     string                 `json:"label"`
+	Status    InstanceSnapshotStatus `json:"status"`
+	Type      string                 `json:"type"`
+	Created   *time.Time             `json:"-"`
+	Updated   *time.Time             `json:"-"`
+	Finished  *time.Time             `json:"-"`
+	Configs   []string               `json:"configs"`
+	Disks     []InstanceSnapshotDisk `json:"disks"`
+	Available bool                   `json:"available"`
 }
 
 // InstanceSnapshotDisk fields represent the source disk of a Snapshot

instances.go

@@ -57,7 +57,7 @@ type Instance struct {
 	Backups             *InstanceBackup         `json:"backups"`
 	Image               string                  `json:"image"`
 	Group               string                  `json:"group"`
-	IPv4                []*net.IP               `json:"ipv4"`
+	IPv4                []net.IP                `json:"ipv4"`
 	IPv6                string                  `json:"ipv6"`
 	Label               string                  `json:"label"`
 	Type                string                  `json:"type"`

nodebalancer.go

@@ -72,12 +72,12 @@ type NodeBalancerCreateOptions struct {
 	// NOTE: ClientUDPSessThrottle may not currently be available to all users.
 	ClientUDPSessThrottle *int `json:"client_udp_sess_throttle,omitzero"`
 
-	Configs    []*NodeBalancerConfigCreateOptions `json:"configs,omitzero"`
-	Tags       []string                           `json:"tags"`
-	FirewallID int                                `json:"firewall_id,omitzero"`
-	Type       NodeBalancerPlanType               `json:"type,omitzero"`
-	VPCs       []NodeBalancerVPCOptions           `json:"vpcs,omitzero"`
-	IPv4       *string                            `json:"ipv4,omitzero"`
+	Configs    []NodeBalancerConfigCreateOptions `json:"configs,omitzero"`
+	Tags       []string                          `json:"tags"`
+	FirewallID int                               `json:"firewall_id,omitzero"`
+	Type       NodeBalancerPlanType              `json:"type,omitzero"`
+	VPCs       []NodeBalancerVPCOptions          `json:"vpcs,omitzero"`
+	IPv4       *string                           `json:"ipv4,omitzero"`
 }
 
 // NodeBalancerUpdateOptions are the options permitted for UpdateNodeBalancer

test/integration/fixtures/TestEventPoller_Secondary.yaml

@@ -19,15 +19,15 @@ func TestVLANs_List_smoke(t *testing.T) {
 	client, fixturesTeardown := createTestClient(t, "fixtures/TestVLANs_List")
 	defer fixturesTeardown()
 
-	var instances []*linodego.Instance
+	var instances []linodego.Instance
 	for i := 0; i < 2; i++ {
 		instance, instanceTeardown, err := createVLANInstance(t, client, fmt.Sprintf("%s-%d", instancePrefix, i), vlanName)
 		if err != nil {
 			t.Fatal(err)
 		}
 		defer instanceTeardown()
 
-		instances = append(instances, instance)
+		instances = append(instances, *instance)
 	}
 
 	for _, instance := range instances {

test/integration/fixtures/TestVLANs_List.yaml

@@ -177,7 +177,7 @@ func TestEventPoller_Secondary(t *testing.T) {
 	}
 
 	// Create two instance disks
-	disks := make([]*linodego.InstanceDisk, 2)
+	disks := make([]linodego.InstanceDisk, 2)
 
 	for i := 0; i < 2; i++ {
 		disk, err := client.CreateInstanceDisk(context.Background(), instance.ID, linodego.InstanceDiskCreateOptions{
@@ -188,7 +188,7 @@ func TestEventPoller_Secondary(t *testing.T) {
 			t.Fatalf("failed to create instance disk: %s", err)
 		}
 
-		disks[i] = disk
+		disks[i] = *disk
 	}
 
 	// Poll for the first disk to be deleted

test/integration/vlans_test.go

@@ -24,7 +24,7 @@ func TestNodeBalancers_UDP(t *testing.T) {
 		Label:                 linodego.Pointer("foobar"),
 		Region:                "us-mia",
 		ClientUDPSessThrottle: linodego.Pointer(5),
-		Configs: []*linodego.NodeBalancerConfigCreateOptions{
+		Configs: []linodego.NodeBalancerConfigCreateOptions{
 			{
 				Protocol:     linodego.ProtocolUDP,
 				Port:         1234,