linodego v2 (#973)

* TPT-4423: Drop resty as a dependency (#938)

* Ported resty removal changes to new branch from up-to-date main and made additional changes to monitor client

* Fixed lint

* Updated log formatting to more closely resemble Resty's

* Fixed lint

* redact request header log

* Fixes

* Fixed CoPilot suggestions

* Sanitize log output

* Addressed CoPilot comments

---------

Co-authored-by: Zhiwei Liang <zliang@akamai.com>

* TPT-4421: Remove deprecated fields and methods (#946)

* Removed deprecated fields and methods and updated tests

* Fix lint

* Addressed copilot suggestion

* Fixed lint

* Removed V2 suffix from various fields and methods

* Addressed CoPilot suggestions

* Added separate struct for Instance IP Address update options

* Address PR suggestions

* TPT-4414: Refactor JSON tags to use "omitzero" for optional fields across multiple files (#947)

* Refactor JSON struct tags to use "omitzero" for optional fields

* Remove url tags in pagination structs

* TPT-4414: Change slice pointer types with `omitzero` to be slice (#954)

* Refactor: Change pointer slices to slices for various fields with omitzero

* Refresh fixtures

* Update TestLKECluster_Update to remove pinned lke versions in test

* TPT-4434: Added custom type for Region Capabilities and updated tests (#953)

* Added custom type for Region Capabilities and updated tests

* Fix formatting

* Added disctinction between Object Storage Bucket Access POST/PUT endpoints (#951)

* TPT-3454: Refactor wait functions to use context for timeouts and polling (#964)

* Refactor wait functions to use context for timeouts and polling

* fix context cancelled in cleanup

* nolint generic return type

* Fix grammar

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

* Make preTask a private function; cleanup unnecessary previousEvents allocation

* Fix error msg format

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

---------

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

* TPT-4422: Added options structs for POST/PUT endpoints that were missing them (#968)

* Added options structs for POST/PUT endpoints that were missing them

* Address PR comments

* Address PR comments

* TPT-3483: Update NewClient method to return an error rather than just logging errors (#967)

* refactor: update NewClient and related functions to handle errors properly

* refactor: update SetRootCertificate to return errors and enhance logging

* update NewClient instantiation to handle errors

* Export PaginatedResponse type in request_helpers (#970)

* TPT-3388: Separated GET and POST/PUT options structs where needed (#969)

* Separated GET and POST/PUT options structs where needed

* Separated additional structs that were reused for options and response

* More struct fixes

* Fix lint

* Rename FirewallRule structs

* integration test fixes

* Addressed PR comments

* FirewallRuleSetRule options; test updates; fixture refreshed

* Address more PR comments

---------

Co-authored-by: Zhiwei Liang <zliang@akamai.com>

* TPT-4464: Update FirewallDeviceEntity Label field to be a pointer (#971)

* Update FirewallDeviceEntity Label field to be a pointer and adjust tests accordingly

* Fix unit tests

* fmt

* Fix another unit test

* Change `[]*T` to `[]T` in all structs (#972)

* Remove LKE cluster dashboard function, tests, and related fixture (#975)

* Simplify client.go (#976)

Signed-off-by: Zhiwei Liang <zhiwei.liang@zliang.me>

* Apply suggestion from @zliang-akamai

* Update region capability in TestImageSharing_Suite to use Linodes

---------

Signed-off-by: Zhiwei Liang <zhiwei.liang@zliang.me>
Co-authored-by: Erik Zilber <ezilber@akamai.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Zhiwei Liang <zhiwei.liang@zliang.me>

Author: 4 people

README.md

@@ -54,7 +54,10 @@ func main() {
 		},
 	}
 
-	linodeClient := linodego.NewClient(oauth2Client)
+	linodeClient, err := linodego.NewClient(oauth2Client)
+	if err != nil {
+		log.Fatal(err)
+	}
 	linodeClient.SetDebug(true)
 
 	res, err := linodeClient.GetInstance(context.Background(), 4090913)

account.go

@@ -34,18 +34,18 @@ type Account struct {
 
 // AccountUpdateOptions fields are those accepted by UpdateAccount
 type AccountUpdateOptions struct {
-	Address1  string `json:"address_1,omitempty"`
-	Address2  string `json:"address_2,omitempty"`
-	City      string `json:"city,omitempty"`
-	Company   string `json:"company,omitempty"`
-	Country   string `json:"country,omitempty"`
-	Email     string `json:"email,omitempty"`
-	FirstName string `json:"first_name,omitempty"`
-	LastName  string `json:"last_name,omitempty"`
-	Phone     string `json:"phone,omitempty"`
-	State     string `json:"state,omitempty"`
-	TaxID     string `json:"tax_id,omitempty"`
-	Zip       string `json:"zip,omitempty"`
+	Address1  string `json:"address_1,omitzero"`
+	Address2  string `json:"address_2,omitzero"`
+	City      string `json:"city,omitzero"`
+	Company   string `json:"company,omitzero"`
+	Country   string `json:"country,omitzero"`
+	Email     string `json:"email,omitzero"`
+	FirstName string `json:"first_name,omitzero"`
+	LastName  string `json:"last_name,omitzero"`
+	Phone     string `json:"phone,omitzero"`
+	State     string `json:"state,omitzero"`
+	TaxID     string `json:"tax_id,omitzero"`
+	Zip       string `json:"zip,omitzero"`
 }
 
 // GetUpdateOptions converts an Account to AccountUpdateOptions for use in UpdateAccount

account_agreements.go

@@ -11,9 +11,9 @@ type AccountAgreements struct {
 
 // AccountAgreementsUpdateOptions fields are those accepted by UpdateAccountAgreements
 type AccountAgreementsUpdateOptions struct {
-	EUModel                bool `json:"eu_model,omitempty"`
-	MasterServiceAgreement bool `json:"master_service_agreement,omitempty"`
-	PrivacyPolicy          bool `json:"privacy_policy,omitempty"`
+	EUModel                bool `json:"eu_model,omitzero"`
+	MasterServiceAgreement bool `json:"master_service_agreement,omitzero"`
+	PrivacyPolicy          bool `json:"privacy_policy,omitzero"`
 }
 
 // GetUpdateOptions converts an AccountAgreements to AccountAgreementsUpdateOptions for use in UpdateAccountAgreements

account_events.go

@@ -231,14 +231,6 @@ const (
 	ActionVPCSubnetCreate                         EventAction = "subnet_create"
 	ActionVPCSubnetDelete                         EventAction = "subnet_delete"
 	ActionVPCSubnetUpdate                         EventAction = "subnet_update"
-
-	// Deprecated: incorrect spelling,
-	// to be removed in the next major version release.
-	ActionVolumeDelte EventAction = "volume_delete"
-
-	// Deprecated: incorrect spelling,
-	// to be removed in the next major version
-	ActionCreateCardUpdated = ActionCreditCardUpdated
 )
 
 // EntityType constants start with Entity and include Linode API Event Entity Types
@@ -343,16 +335,6 @@ func (c *Client) GetEvent(ctx context.Context, eventID int) (*Event, error) {
 	return doGETRequest[Event](ctx, c, e)
 }
 
-// MarkEventRead marks a single Event as read.
-//
-// Deprecated: `MarkEventRead` is a deprecated API, please consider using `MarkEventsSeen` instead.
-// Please note that the `MarkEventsSeen` API functions differently and will mark all events up to and
-// including the referenced event-id as "seen" rather than individual events.
-func (c *Client) MarkEventRead(ctx context.Context, event *Event) error {
-	e := formatAPIPath("account/events/%d/read", event.ID)
-	return doPOSTRequestNoRequestResponseBody(ctx, c, e)
-}
-
 // MarkEventsSeen marks all Events up to and including this Event by ID as seen.
 func (c *Client) MarkEventsSeen(ctx context.Context, event *Event) error {
 	e := formatAPIPath("account/events/%d/seen", event.ID)

account_maintenance.go

@@ -22,9 +22,6 @@ type AccountMaintenance struct {
 	NotBefore    *time.Time `json:"-"`
 	StartTime    *time.Time `json:"-"`
 	CompleteTime *time.Time `json:"-"`
-
-	// Deprecated: When is a deprecated property
-	When *time.Time `json:"when"`
 }
 
 // Entity represents the entity being affected by maintenance
@@ -57,7 +54,6 @@ func (accountMaintenance *AccountMaintenance) UnmarshalJSON(b []byte) error {
 	accountMaintenance.NotBefore = (*time.Time)(p.NotBefore)
 	accountMaintenance.StartTime = (*time.Time)(p.StartTime)
 	accountMaintenance.CompleteTime = (*time.Time)(p.CompleteTime)
-	accountMaintenance.When = (*time.Time)(p.When)
 
 	return nil
 }

account_oauth_client.go

@@ -111,5 +111,5 @@ func (c *Client) DeleteOAuthClient(ctx context.Context, clientID string) error {
 // ResetOAuthClientSecret resets the OAuth Client secret for a client with a specified id
 func (c *Client) ResetOAuthClientSecret(ctx context.Context, clientID string) (*OAuthClient, error) {
 	e := formatAPIPath("account/oauth-clients/%s/reset-secret", clientID)
-	return doPOSTRequest[OAuthClient, any](ctx, c, e)
+	return doPOSTRequestNoRequestBody[OAuthClient](ctx, c, e)
 }

account_payments.go

@@ -23,7 +23,7 @@ type Payment struct {
 // PaymentCreateOptions fields are those accepted by CreatePayment
 type PaymentCreateOptions struct {
 	// CVV (Card Verification Value) of the credit card to be used for the Payment
-	CVV string `json:"cvv,omitempty"`
+	CVV string `json:"cvv,omitzero"`
 
 	// The amount, in US dollars, of the Payment
 	USD json.Number `json:"usd"`

account_settings.go

@@ -40,17 +40,17 @@ type AccountSettings struct {
 // AccountSettingsUpdateOptions are the updateable account wide flags or plans that effect new resources.
 type AccountSettingsUpdateOptions struct {
 	// The default backups enrollment status for all new Linodes for all users on the account.  When enabled, backups are mandatory per instance.
-	BackupsEnabled *bool `json:"backups_enabled,omitempty"`
+	BackupsEnabled *bool `json:"backups_enabled,omitzero"`
 
 	// The default network helper setting for all new Linodes and Linode Configs for all users on the account.
-	NetworkHelper *bool `json:"network_helper,omitempty"`
+	NetworkHelper *bool `json:"network_helper,omitzero"`
 
 	// NOTE: Interfaces for new linode setting may not currently be available to all users.
 	// A new configuration flag defines whether new Linodes can use Linode and/or legacy config interfaces.
 	InterfacesForNewLinodes *InterfacesForNewLinodes `json:"interfaces_for_new_linodes"`
 
 	// The slug of the maintenance policy to set the account to.
-	MaintenancePolicy *string `json:"maintenance_policy,omitempty"`
+	MaintenancePolicy *string `json:"maintenance_policy,omitzero"`
 }
 
 // GetAccountSettings gets the account wide flags or plans that effect new resources

account_user_grants.go

@@ -56,17 +56,17 @@ type UserGrants struct {
 }
 
 type UserGrantsUpdateOptions struct {
-	Database       []GrantedEntity   `json:"database,omitempty"`
-	Domain         []EntityUserGrant `json:"domain,omitempty"`
-	Firewall       []EntityUserGrant `json:"firewall,omitempty"`
-	Image          []EntityUserGrant `json:"image,omitempty"`
-	Linode         []EntityUserGrant `json:"linode,omitempty"`
-	Longview       []EntityUserGrant `json:"longview,omitempty"`
-	NodeBalancer   []EntityUserGrant `json:"nodebalancer,omitempty"`
-	PlacementGroup []EntityUserGrant `json:"placement_group,omitempty"`
-	StackScript    []EntityUserGrant `json:"stackscript,omitempty"`
-	Volume         []EntityUserGrant `json:"volume,omitempty"`
-	VPC            []EntityUserGrant `json:"vpc,omitempty"`
+	Database       []GrantedEntity   `json:"database,omitzero"`
+	Domain         []EntityUserGrant `json:"domain,omitzero"`
+	Firewall       []EntityUserGrant `json:"firewall,omitzero"`
+	Image          []EntityUserGrant `json:"image,omitzero"`
+	Linode         []EntityUserGrant `json:"linode,omitzero"`
+	Longview       []EntityUserGrant `json:"longview,omitzero"`
+	NodeBalancer   []EntityUserGrant `json:"nodebalancer,omitzero"`
+	PlacementGroup []EntityUserGrant `json:"placement_group,omitzero"`
+	StackScript    []EntityUserGrant `json:"stackscript,omitzero"`
+	Volume         []EntityUserGrant `json:"volume,omitzero"`
+	VPC            []EntityUserGrant `json:"vpc,omitzero"`
 
 	Global GlobalUserGrants `json:"global"`
 }

account_users.go

@@ -45,9 +45,9 @@ type UserCreateOptions struct {
 
 // UserUpdateOptions fields are those accepted by UpdateUser
 type UserUpdateOptions struct {
-	Username   string `json:"username,omitempty"`
-	Restricted *bool  `json:"restricted,omitempty"`
-	Email      string `json:"email,omitempty"`
+	Username   string `json:"username,omitzero"`
+	Restricted *bool  `json:"restricted,omitzero"`
+	Email      string `json:"email,omitzero"`
 }
 
 // UnmarshalJSON implements the json.Unmarshaler interface