TPT-4277: Implement support for Reserved IP for IPv4 by mgwoj · Pull Request #919 · linode/linodego

mgwoj · 2026-03-23T12:40:37Z

📝 Description

Complete the Go SDK (linodego) support for the Reserved IP feature. Several foundations are already in place; this story addresses the remaining gaps to bring the SDK fully in line with the API Specification.

✔️ How to Test

make test-unit
make TEST_ARGS="-run TestReservedIPAddress" test-int

As the API is not ready yet, there are only mocked integration tests.

* build(deps): bump golang.org/x/oauth2 from 0.35.0 to 0.36.0 Bumps [golang.org/x/oauth2](https://github.com/golang/oauth2) from 0.35.0 to 0.36.0. - [Commits](golang/oauth2@v0.35.0...v0.36.0) --- updated-dependencies: - dependency-name: golang.org/x/oauth2 dependency-version: 0.36.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * make tidy --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Zhiwei Liang <zliang@akamai.com>

…elease notes workflow (linode#913) * Added PR title checking to lint and clean up release notes * Fixed CoPilot suggestions * Exclude dependabot PRs from PR title validation * Address CoPilot suggestions * Add exemptions for hotfixes and external contributions * Switch to using amannn/action-semantic-pull-request@v6 for title validation * Add exemption for dependencies label and remove dependabot author check

* Redact sensitive data from logging * Address copilot suggestions * TPT-4014 Address comments suggestions

Copilot

Pull request overview

Implements remaining Go SDK (linodego) support for the Reserved IPv4 feature to better align with the API spec, primarily by expanding reserved IP metadata support and adding unit coverage.

Changes:

Add reserved_ipv4_addresses support to tag creation and decode tagged objects of type reserved_ipv4_address.
Add reserved IP tags support plus new endpoints for updating a reserved IP and listing reserved IP types (pricing).
Add/extend unit tests and fixtures to validate request bodies and response decoding for reserved IP behavior.

Reviewed changes

Copilot reviewed 15 out of 15 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
`tags.go`	Adds tag create option for reserved IPv4 addresses and decodes tagged reserved IP objects.
`network_reserved_ips.go`	Adds tag support for reserving IPs, plus update + types-list endpoints and related models.
`instance_ips.go`	Extends `InstanceIP` with `tags` field to capture reserved IP tags.
`test/unit/tag_test.go`	Adds unit coverage for tag create with reserved IPv4 addresses and tagged-object decoding.
`test/unit/nodebalancer_test.go`	Adds request-body validation test for NodeBalancer create with `ipv4`.
`test/unit/network_reserved_ips_test.go`	Extends reserved IP tests to cover tags, update, and type listing.
`test/unit/network_ips_test.go`	Adds request-body validation for reserve allocation and combined RDNS+reserved update.
`test/unit/instance_test.go`	Adds request-body validation for instance create with explicit IPv4 list.
`test/unit/instance_ip_test.go`	Adds request-body validation for assigning a reserved IP to an instance.
`test/unit/fixtures/tagged_objects_reserved_ip_list.json`	Adds fixture for tagged reserved IPv4 address objects.
`test/unit/fixtures/network_reserved_ips_list.json`	Updates reserved IP list fixture with `reserved` and `tags`.
`test/unit/fixtures/network_reserved_ips_get.json`	Updates reserved IP get fixture with `reserved` and `tags`.
`test/unit/fixtures/network_reserved_ips.json`	Updates reserve-IP create fixture with `reserved` and `tags`.
`test/unit/fixtures/network_reserved_ip_update.json`	Adds fixture for reserved IP update response.
`test/unit/fixtures/network_reserved_ip_types_list.json`	Adds fixture for reserved IP types (pricing) list response.

Comments suppressed due to low confidence (1)

test/unit/fixtures/network_reserved_ips_list.json:26

This list fixture is missing the standard "page" field used by paginated list responses in this repo's fixtures. If this fixture is used with getPaginatedResults, pagination decoding may fail or behave inconsistently; add "page": 1 to match other list fixtures.

    ],
    "pages": 1,
    "results": 2
}

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

…reateOptions (linode#921) * Update FirewallID to use single pointer in LinodeInterfaceCreateOptions * Fix test

…inode#916) * build(deps): bump slackapi/slack-github-action from 2.1.1 to 3.0.1 Bumps [slackapi/slack-github-action](https://github.com/slackapi/slack-github-action) from 2.1.1 to 3.0.1. - [Release notes](https://github.com/slackapi/slack-github-action/releases) - [Commits](slackapi/slack-github-action@v2.1.1...v3.0.1) --- updated-dependencies: - dependency-name: slackapi/slack-github-action dependency-version: 3.0.1 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * Apply suggestions from code review Co-authored-by: Zhiwei Liang <121905282+zliang-akamai@users.noreply.github.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Zhiwei Liang <121905282+zliang-akamai@users.noreply.github.com>

Bumps [actions/github-script](https://github.com/actions/github-script) from 7 to 8. - [Release notes](https://github.com/actions/github-script/releases) - [Commits](actions/github-script@v7...v8) --- updated-dependencies: - dependency-name: actions/github-script dependency-version: '8' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* TPT-4318: Add @linode/dx-sdets to CODEOWNERS * Correct CODEOWNERS

…node#917) * Added DiskEncryption field for LKE Node Pool creation * Address CoPilot suggestions * Removed more LA notices * Update disk_encryption field to be a pointer

* build(deps): bump golang.org/x/net from 0.51.0 to 0.52.0 Bumps [golang.org/x/net](https://github.com/golang/net) from 0.51.0 to 0.52.0. - [Commits](golang/net@v0.51.0...v0.52.0) --- updated-dependencies: - dependency-name: golang.org/x/net dependency-version: 0.52.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * go mod tidy --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Lena Garber <lgarber@akamai.com>

…field to firewall (linode#901) * Fix firewall device for linode interfaces#829 * Fix unit test * Update the unit test * feat: add entities field to Firewall struct and define FirewallEntity type * Fix unit test * Integration test update * Apply suggestion from @Copilot Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update FirewallDeviceEntity and tests * Reuse FirewallDeviceEntity * fmt * Fix test --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Michal Wojcik <32574975+mgwoj@users.noreply.github.com>

lgarber-akamai

LGTM!

Add entity envelope in AlertDefinition GET, POST and PUT API responses. Add new method to list entities. Update tests.

Copilot

Pull request overview

Copilot reviewed 27 out of 30 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-04-13T18:21:11Z

+// UpdateReservedIPOptions represents the options for updating a reserved IP address
+// NOTE: Reserved IP feature may not currently be available to all users.
+type UpdateReservedIPOptions struct {
+	Tags []string `json:"tags"`
 }


UpdateReservedIPOptions.Tags is a non-pointer slice without omitempty, so the zero value (nil) will marshal as "tags":null. If the API expects an array (even when clearing), this can cause request validation errors or unintended semantics. Consider using Tags *[]string json:"tags,omitempty"`` (consistent with other update options in the SDK) or validate that Tags is non-nil before issuing the PUT.

You can use omitzero instead of omitempty for any list to make sure empty slice are correctly marshalled.

Agree, this is the way to go

yec-akamai

Overall looks good. Is the security vulnerability related to this change?

…upport-for-reserved-ip-for-ipv4

mgwoj · 2026-04-15T11:08:25Z

Overall looks good. Is the security vulnerability related to this change?

No, it is not related at all

dependabot bot and others added 4 commits March 13, 2026 15:12

TPT-4014: Redact sensitive data from logging (linode#906)

76d9391

* Redact sensitive data from logging * Address copilot suggestions * TPT-4014 Address comments suggestions

TPT-4277 Implement support for Reserved IP for IPv4

802f57f

mgwoj requested a review from a team as a code owner March 23, 2026 12:40

mgwoj requested review from Copilot, vshanthe and yec-akamai and removed request for a team March 23, 2026 12:40

Copilot started reviewing on behalf of mgwoj March 23, 2026 12:41 View session

Copilot AI reviewed Mar 23, 2026

View reviewed changes

Comment thread network_reserved_ips.go Outdated

mgwoj and others added 2 commits March 23, 2026 14:23

Update network_reserved_ips.go

3d04bdc

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

TPT-4277 Implement support for Reserved IP for IPv4

2264a2e

mgwoj changed the title ~~TPT-4277 Implement support for Reserved IP for IPv4~~ feat: TPT-4277 Implement support for Reserved IP for IPv4 Mar 23, 2026

mgwoj added the new-feature for new features in the changelog. label Mar 24, 2026

mgwoj changed the base branch from main to proj/reserved-ips March 24, 2026 13:45

mgwoj changed the title ~~feat: TPT-4277 Implement support for Reserved IP for IPv4~~ TPT-4277 Implement support for Reserved IP for IPv4 Mar 24, 2026

TPT-4320: Update FirewallID to use single pointer in LinodeInterfaceC…

dc00ea0

…reateOptions (linode#921) * Update FirewallID to use single pointer in LinodeInterfaceCreateOptions * Fix test

mgwoj changed the title ~~TPT-4277 Implement support for Reserved IP for IPv4~~ TPT-4277: Implement support for Reserved IP for IPv4 Mar 25, 2026

mgwoj requested review from lgarber-akamai and removed request for vshanthe March 25, 2026 10:46

dependabot bot and others added 9 commits March 25, 2026 15:49

TPT-4277 Implement support for Reserved IP for IPv4

492a403

TPT-4277 Implement support for Reserved IP for IPv4

0606e68

TPT-4318: Add @linode/dx-sdets to CODEOWNERS (linode#920)

fb8c404

* TPT-4318: Add @linode/dx-sdets to CODEOWNERS * Correct CODEOWNERS

TPT-3807: Added DiskEncryption field for LKE Node Pool creation (li…

69df217

…node#917) * Added DiskEncryption field for LKE Node Pool creation * Address CoPilot suggestions * Removed more LA notices * Update disk_encryption field to be a pointer

Cleanup LA notices for block storage encryption (linode#902)

09803f2

lgarber-akamai approved these changes Apr 7, 2026

View reviewed changes

shkaruna added 2 commits April 8, 2026 12:59

Remove content field from list alert channels response (linode#925)

04c1c9e

feat: add ACLP list entities method (linode#923)

ad25985

Add entity envelope in AlertDefinition GET, POST and PUT API responses. Add new method to list entities. Update tests.

yec-akamai requested a review from Copilot April 13, 2026 18:14

Copilot started reviewing on behalf of yec-akamai April 13, 2026 18:15 View session

Copilot AI reviewed Apr 13, 2026

View reviewed changes

yec-akamai reviewed Apr 13, 2026

View reviewed changes

Merge branch 'linode:main' into feature/TPT-4277-linodego-implement-s…

f1eb655

…upport-for-reserved-ip-for-ipv4

TPT-4277: Implement support for Reserved IP for IPv4

e150bbf

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

TPT-4277: Implement support for Reserved IP for IPv4#919

TPT-4277: Implement support for Reserved IP for IPv4#919
mgwoj wants to merge 20 commits intolinode:proj/reserved-ipsfrom
mgwoj:feature/TPT-4277-linodego-implement-support-for-reserved-ip-for-ipv4

mgwoj commented Mar 23, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

lgarber-akamai left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI Apr 13, 2026

Uh oh!

yec-akamai Apr 13, 2026 •

edited

Loading

Uh oh!

mgwoj Apr 15, 2026

Uh oh!

yec-akamai left a comment

Uh oh!

mgwoj commented Apr 15, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Conversation

mgwoj commented Mar 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📝 Description

✔️ How to Test

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

lgarber-akamai left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI Apr 13, 2026

Choose a reason for hiding this comment

Uh oh!

yec-akamai Apr 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mgwoj Apr 15, 2026

Choose a reason for hiding this comment

Uh oh!

yec-akamai left a comment

Choose a reason for hiding this comment

Uh oh!

mgwoj commented Apr 15, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

mgwoj commented Mar 23, 2026 •

edited

Loading

yec-akamai Apr 13, 2026 •

edited

Loading