TPT-4281: Remove v4beta lock usage notes from instances, locks, and nodebalance…#929
Open
zliang-akamai wants to merge 1 commit intolinode:mainfrom
Open
TPT-4281: Remove v4beta lock usage notes from instances, locks, and nodebalance…#929zliang-akamai wants to merge 1 commit intolinode:mainfrom
zliang-akamai wants to merge 1 commit intolinode:mainfrom
Conversation
zliang-akamai
requested review from
ckulinsk and
jbilskiAkam
and removed request for
a team
zliang-akamai
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
Removes outdated documentation notes indicating that resource locks are “v4beta-only” from core types and APIs, aligning the Go client’s inline docs with current API expectations.
Changes:
- Removed the “Locks can only be used with v4beta” note from
Instance.Locks. - Removed the same note from
NodeBalancer.Locks. - Removed repeated v4beta-only notes from
locks.gotype and method doc comments.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
nodebalancer.go |
Removes v4beta-only usage note from the Locks field doc comment. |
locks.go |
Removes repeated v4beta-only notes across lock types and CRUD/list methods. |
instances.go |
Removes v4beta-only usage note from the Locks field doc comment. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
Remove v4beta lock usage notes from instances, locks, and nodebalancer files