TPT-4471: deduplicate logger setup and retry-loop body seek#976
Merged
zliang-akamai merged 2 commits intoMay 27, 2026
Merged
Conversation
ChihweiLHBird
requested review from
jriddle-linode and
mawilk90
and removed request for
a team
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR adjusts request/response logging and retry handling in the Go client, primarily by simplifying retry behavior and changing how debug logs are formatted/emitted.
Changes:
- Removes explicit request-body seeking in the retry loop and relies on
createRequestto reset the body. - Refactors request/response logging to remove sanitization and simplify JSON formatting/log emission.
- Removes the Resty logger configuration (
SetLogger(createLogger())) during client construction.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
zliang-akamai
added
the
community-contribution
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
ChihweiLHBird
force-pushed
the
zhiwei/client-simplified
branch
from
89f7377 to
d54d126
Compare
Signed-off-by: Zhiwei Liang <zhiwei.liang@zliang.me>
ChihweiLHBird
force-pushed
the
zhiwei/client-simplified
branch
from
d54d126 to
db4352a
Compare
zliang-akamai
changed the title
zliang-akamai
changed the title
zliang-akamai
removed
the
community-contribution
ezilber-akamai
approved these changes
May 26, 2026
Contributor
ezilber-akamai
left a comment
ezilber-akamai
left a comment
There was a problem hiding this comment.
Thanks for fixing this!
lgarber-akamai
approved these changes
May 27, 2026
Contributor
lgarber-akamai
left a comment
lgarber-akamai
left a comment
There was a problem hiding this comment.
Wasn't able to find any bugs hiding in this, great work!
zliang-akamai
added a commit
that referenced
this pull request
May 27, 2026
* TPT-4423: Drop resty as a dependency (#938) * Ported resty removal changes to new branch from up-to-date main and made additional changes to monitor client * Fixed lint * Updated log formatting to more closely resemble Resty's * Fixed lint * redact request header log * Fixes * Fixed CoPilot suggestions * Sanitize log output * Addressed CoPilot comments --------- Co-authored-by: Zhiwei Liang <zliang@akamai.com> * TPT-4421: Remove deprecated fields and methods (#946) * Removed deprecated fields and methods and updated tests * Fix lint * Addressed copilot suggestion * Fixed lint * Removed V2 suffix from various fields and methods * Addressed CoPilot suggestions * Added separate struct for Instance IP Address update options * Address PR suggestions * TPT-4414: Refactor JSON tags to use "omitzero" for optional fields across multiple files (#947) * Refactor JSON struct tags to use "omitzero" for optional fields * Remove url tags in pagination structs * TPT-4414: Change slice pointer types with `omitzero` to be slice (#954) * Refactor: Change pointer slices to slices for various fields with omitzero * Refresh fixtures * Update TestLKECluster_Update to remove pinned lke versions in test * TPT-4434: Added custom type for Region Capabilities and updated tests (#953) * Added custom type for Region Capabilities and updated tests * Fix formatting * Added disctinction between Object Storage Bucket Access POST/PUT endpoints (#951) * TPT-3454: Refactor wait functions to use context for timeouts and polling (#964) * Refactor wait functions to use context for timeouts and polling * fix context cancelled in cleanup * nolint generic return type * Fix grammar Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> * Make preTask a private function; cleanup unnecessary previousEvents allocation * Fix error msg format Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> * TPT-4422: Added options structs for POST/PUT endpoints that were missing them (#968) * Added options structs for POST/PUT endpoints that were missing them * Address PR comments * Address PR comments * TPT-3483: Update NewClient method to return an error rather than just logging errors (#967) * refactor: update NewClient and related functions to handle errors properly * refactor: update SetRootCertificate to return errors and enhance logging * update NewClient instantiation to handle errors * Export PaginatedResponse type in request_helpers (#970) * TPT-3388: Separated GET and POST/PUT options structs where needed (#969) * Separated GET and POST/PUT options structs where needed * Separated additional structs that were reused for options and response * More struct fixes * Fix lint * Rename FirewallRule structs * integration test fixes * Addressed PR comments * FirewallRuleSetRule options; test updates; fixture refreshed * Address more PR comments --------- Co-authored-by: Zhiwei Liang <zliang@akamai.com> * TPT-4464: Update FirewallDeviceEntity Label field to be a pointer (#971) * Update FirewallDeviceEntity Label field to be a pointer and adjust tests accordingly * Fix unit tests * fmt * Fix another unit test * Change `[]*T` to `[]T` in all structs (#972) * Remove LKE cluster dashboard function, tests, and related fixture (#975) * Simplify client.go (#976) Signed-off-by: Zhiwei Liang <zhiwei.liang@zliang.me> * Apply suggestion from @zliang-akamai * Update region capability in TestImageSharing_Suite to use Linodes --------- Signed-off-by: Zhiwei Liang <zhiwei.liang@zliang.me> Co-authored-by: Erik Zilber <ezilber@akamai.com> Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Co-authored-by: Zhiwei Liang <zhiwei.liang@zliang.me>
zliang-akamai
added
the
improvement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
SetLogger(createLogger())fromNewClientchain (client.go:215). The same setter at line 186 already installed an identical logger, and no intermediate call reads or replaces it.doRequest's retry loop.createRequest(called immediately after) performs the sameparams.Body.Seek(0)on the same buffer, so the outer seek was always a no-op.json.Unmarshal's error check informatBody. Standardif err := json.Unmarshal(...); err != nilform,erris only used inside the immediately following branch.Test plan