fix: [DPS-41226][CMJPOC-7] - Errors while searching for services in cloud manager (#13459)

Author: kagora-akamai

packages/manager/.changeset/pr-13459-fixed-1772610765361.md

@@ -0,0 +1,5 @@
+---
+"@linode/manager": Fixed
+---
+
+Unnecessary API requests for Delivery services while searching when feature access is not present ([#13459](https://github.com/linode/manager/pull/13459))

packages/manager/src/features/Search/useAPISearch.ts

@@ -13,6 +13,7 @@ import {
 import { getAPIFilterFromQuery } from '@linode/search';
 import { useDebouncedValue } from '@linode/utilities';
 
+import { useIsACLPLogsEnabled } from 'src/features/Delivery/deliveryUtils';
 import { useKubernetesClustersInfiniteQuery } from 'src/queries/kubernetes';
 import {
   databaseToSearchableItem,
@@ -119,6 +120,7 @@ const entities = [
     searchOptions: {
       searchableFieldsWithoutOperator: ['label'],
     },
+    requireACLPLogsEnabled: true,
   },
   {
     getSearchableItem: destinationToSearchableItem,
@@ -127,6 +129,7 @@ const entities = [
     searchOptions: {
       searchableFieldsWithoutOperator: ['label'],
     },
+    requireACLPLogsEnabled: true,
   },
 ];
 
@@ -142,11 +145,12 @@ const entities = [
  * and do the filtering client-side.
  */
 export const useAPISearch = ({ enabled, query }: Props) => {
-  const deboundedQuery = useDebouncedValue(query);
+  const debouncedQuery = useDebouncedValue(query);
+  const { isACLPLogsEnabled } = useIsACLPLogsEnabled();
 
   const result = entities.map((entity) => {
     const { error, filter } = getAPIFilterFromQuery(
-      deboundedQuery,
+      debouncedQuery,
       entity.searchOptions
     );
 
@@ -155,7 +159,10 @@ export const useAPISearch = ({ enabled, query }: Props) => {
       parseError: error,
       ...entity.query(
         entity.baseFilter ? { ...entity.baseFilter, ...filter } : filter,
-        enabled && error === null && Boolean(deboundedQuery)
+        enabled &&
+          error === null &&
+          Boolean(debouncedQuery) &&
+          (!entity.requireACLPLogsEnabled || isACLPLogsEnabled)
       ),
     };
   });

packages/manager/src/features/Search/useClientSideSearch.ts

@@ -11,6 +11,7 @@ import {
   useAllVolumesQuery,
 } from '@linode/queries';
 
+import { useIsACLPLogsEnabled } from 'src/features/Delivery/deliveryUtils';
 import { useAllKubernetesClustersQuery } from 'src/queries/kubernetes';
 import { useObjectStorageBuckets } from 'src/queries/object-storage/queries';
 import {
@@ -44,6 +45,7 @@ interface Props {
  */
 export const useClientSideSearch = ({ enabled, query }: Props) => {
   const { isPrivateImageSharingEnabled } = useIsPrivateImageSharingEnabled();
+  const { isACLPLogsEnabled } = useIsACLPLogsEnabled();
 
   const {
     data: domains,
@@ -96,12 +98,12 @@ export const useClientSideSearch = ({ enabled, query }: Props) => {
     data: streams,
     error: streamsError,
     isLoading: streamsLoading,
-  } = useAllStreamsQuery({}, {}, enabled);
+  } = useAllStreamsQuery({}, {}, enabled && isACLPLogsEnabled);
   const {
     data: destinations,
     error: destinationsError,
     isLoading: destinationsLoading,
-  } = useAllDestinationsQuery({}, {}, enabled);
+  } = useAllDestinationsQuery({}, {}, enabled && isACLPLogsEnabled);
 
   const searchableDomains = domains?.map(domainToSearchableItem) ?? [];
   const searchableVolumes = volumes?.map(volumeToSearchableItem) ?? [];

packages/manager/src/store/selectors/getSearchEntities.ts

@@ -215,6 +215,7 @@ export const streamToSearchableItem = (stream: Stream): SearchableItem => ({
     description: getStreamDescription(stream),
     path: `/logs/delivery/streams/${stream.id}/edit`,
     status: stream.status,
+    created: stream.created,
   },
   entityType: 'stream',
   label: stream.label,
@@ -227,6 +228,7 @@ export const destinationToSearchableItem = (
   data: {
     description: getDestinationDescription(destination),
     path: `/logs/delivery/destinations/${destination.id}/edit`,
+    created: destination.created,
   },
   entityType: 'destination',
   label: destination.label,