Skip to content

TPT-4160: Add Listing ACLP Alert Channels Data Source#2296

Merged
yec-akamai merged 17 commits intoproj/aclp-alerting-definitionfrom
TPT-4160/alert-channels
May 6, 2026
Merged

TPT-4160: Add Listing ACLP Alert Channels Data Source#2296
yec-akamai merged 17 commits intoproj/aclp-alerting-definitionfrom
TPT-4160/alert-channels

Conversation

@yec-akamai
Copy link
Copy Markdown
Contributor

📝 Description

Add a data source for listing ACLP alert channels.

✔️ How to Test

make test-unit
make test-int PKG_NAME=monitoralertchannels 

@yec-akamai yec-akamai added the new-feature for new features in the changelog. label Mar 10, 2026
@yec-akamai yec-akamai requested a review from a team as a code owner March 10, 2026 20:17
@yec-akamai yec-akamai requested review from ckulinsk, Copilot and mawilk90 and removed request for a team March 10, 2026 20:17
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a new Terraform Plugin Framework data source, linode_monitor_alert_channels, to list Linode Monitor Alert notification channels (with optional filtering), along with tests, templates, documentation, and provider registration. It also updates module dependencies to pick up the required Linodego API support.

Changes:

  • Implement linode_monitor_alert_channels framework data source (schema, models/flattening, read/list logic).
  • Add unit + integration tests and acceptance templates for basic and filtered queries.
  • Register the data source in the framework provider and add user documentation; update Go/dependencies (incl. Linodego).

Reviewed changes

Copilot reviewed 11 out of 12 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
linode/monitoralertchannels/framework_datasource.go Data source Read implementation and API listing function
linode/monitoralertchannels/framework_schema_datasource.go Data source schema + filterable fields configuration
linode/monitoralertchannels/framework_models.go Terraform state models and API→state flattening helpers
linode/monitoralertchannels/framework_models_test.go Unit tests for flattening/model parsing
linode/monitoralertchannels/datasource_test.go Integration test coverage for basic + filtered queries
linode/monitoralertchannels/tmpl/template.go Acceptance test template helpers
linode/monitoralertchannels/tmpl/data_basic.gotf HCL template for basic data source config
linode/monitoralertchannels/tmpl/data_filter.gotf HCL template for filtered data source config
linode/framework_provider.go Registers the new data source with the framework provider
docs/data-sources/monitor_alert_channels.md Adds end-user docs for the new data source
go.mod Updates Go version/deps; adds Linodego override
go.sum Dependency checksum updates corresponding to go.mod changes

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread go.mod
Comment thread go.mod Outdated
Comment thread linode/monitoralertchannels/framework_models.go Outdated
Comment thread linode/monitoralertchannels/framework_datasource.go
Comment thread linode/monitoralertchannels/framework_datasource.go
Comment thread docs/data-sources/monitor_alert_channels.md Outdated
Copy link
Copy Markdown
Member

@zliang-akamai zliang-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mawilk90 mawilk90 requested review from psnoch-akamai and removed request for mawilk90 March 20, 2026 13:08
@yec-akamai yec-akamai changed the base branch from dev to proj/aclp-alerting-definition March 26, 2026 15:45
@yec-akamai yec-akamai requested a review from a team as a code owner March 26, 2026 15:45
@yec-akamai yec-akamai requested review from mawilk90 and removed request for a team March 26, 2026 15:45
@yec-akamai yec-akamai force-pushed the TPT-4160/alert-channels branch from 328d115 to 3f668ab Compare April 10, 2026 18:58
@mawilk90 mawilk90 removed their request for review April 16, 2026 11:33
Comment thread linode/monitoralertchannels/framework_models_test.go Outdated
@yec-akamai yec-akamai changed the title Add Listing ACLP Alert Channels Data Source TPT-4160: Add Listing ACLP Alert Channels Data Source May 6, 2026
Copy link
Copy Markdown

@psnoch-akamai psnoch-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good for me. Tests work locally

@yec-akamai yec-akamai merged commit 7b4ce65 into proj/aclp-alerting-definition May 6, 2026
12 checks passed
@yec-akamai yec-akamai deleted the TPT-4160/alert-channels branch May 6, 2026 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new-feature for new features in the changelog.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants