Fix linode_instance_config boot behavior to match linode_instance#2307
Open
cheeseburgermotivated wants to merge 1 commit into
Open
Fix linode_instance_config boot behavior to match linode_instance#2307cheeseburgermotivated wants to merge 1 commit into
cheeseburgermotivated wants to merge 1 commit into
Conversation
When the `booted` attribute is omitted in linode_instance_config, the resource previously would not boot newly created instances. This was inconsistent with linode_instance (with inline configs), which boots new instances automatically when `booted` is not specified. This inconsistency forced users to set `booted = true`, which caused Terraform to enforce the power state on every apply. This meant that instances manually shut down through Cloud Manager, API, or CLI would be powered back on during terraform plan/apply, which is undesirable. Changes: - Modified createResource to boot instances when `booted` is null or true - Instances now boot automatically on creation when `booted` is omitted - Power state management only occurs when `booted` is explicitly set - Updated schema description to clarify the new behavior - Added TestAccResourceInstanceConfig_bootedDefault to verify fix This aligns the behavior with linode_instance: omitting `booted` boots new instances but doesn't force power state changes on existing ones, while setting `booted = true/false` provides explicit control. Fixes behavior reported in user feedback where manually shut-down instances were unintentionally powered on during terraform operations. Co-authored-by: GitHub Copilot <noreply@github.com>
cheeseburgermotivated
requested review from
jriddle-linode,
lgarber-akamai and
psnoch-akamai
and removed request for
a team
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the
bootedattribute is omitted in linode_instance_config, the resource previously would not boot newly created instances. This was inconsistent with linode_instance (with inline configs), which boots new instances automatically whenbootedis not specified.This inconsistency forced users to set
booted = true, which caused Terraform to enforce the power state on every apply. This meant that instances manually shut down through Cloud Manager, API, or CLI would be powered back on during terraform plan/apply, which is undesirable.Changes:
bootedis null or truebootedis omittedbootedis explicitly setThis aligns the behavior with linode_instance: omitting
bootedboots new instances but doesn't force power state changes on existing ones, while settingbooted = true/falseprovides explicit control.Fixes behavior reported in user feedback where manually shut-down instances were unintentionally powered on during terraform operations.
Co-authored-by: GitHub Copilot noreply@github.com