TPT-4399: Make nat_1_1 attribute as non-computed#2341
Open
zliang-akamai wants to merge 3 commits intolinode:devfrom
Open
TPT-4399: Make nat_1_1 attribute as non-computed#2341zliang-akamai wants to merge 3 commits intolinode:devfrom
nat_1_1 attribute as non-computed#2341zliang-akamai wants to merge 3 commits intolinode:devfrom
Conversation
zliang-akamai
changed the title
nat_1_1 attribute as non-computednat_1_1 attribute as non-computed
zliang-akamai
changed the title
nat_1_1 attribute as non-computednat_1_1 attribute as non-computed
zliang-akamai
force-pushed
the
zhiwei/fix-instance-nat-1-1
branch
from
837f313 to
b7dcdd3
Compare
zliang-akamai
requested review from
a team,
ckulinsk,
jriddle-linode and
mgwoj
and removed request for
a team
Contributor
|
Should we add test exposing this scenario? |
mgwoj
approved these changes
May 7, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Linode Instance network interface schema so nat_1_1 is no longer treated as a computed attribute, allowing Terraform to detect and plan changes when users remove nat_1_1 from their .tf configuration.
Changes:
- Remove
Computed: truefrom thenat_1_1attribute within the VPC interface IPv4 schema. - Preserve existing behavior for
nat_1_1 = "any"via the existingDiffSuppressFunc.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
Making
nat_1_1attribute as non-computed to trigger diff when the attribute is removed from the.tfconfig files.✔️ How to Test