ACLP Logs by klipensk · Pull Request #2359 · linode/terraform-provider-linode

klipensk · 2026-05-25T09:28:01Z

📝 Description

Adds Terraform support for the monitoring log destinations api and streams api.

✔️ How to Test

Unit tests:

log destinations API: make PKG_NAME=monitorlogsdestination test-unit
log streams API: make PKG_NAME=monitorlogsstream test-unit

Integration tests (package specific):

log destinations: LINODE_TOKEN=<your_token> make TEST_SUITE=monitorlogsdestination,monitorlogsdestinations test-int
log streams: LINODE_TOKEN=<your_token> RUN_LONG_TESTS=true TIMEOUT=300m make TEST_SUITE=monitorlogsdestination,monitorlogsdestinations,monitorlogsstream,monitorlogsstreams,monitorlogsstreamhistory test-int

Copilot

Pull request overview

This PR adds Terraform Framework support for Monitor Logs destinations and streams, including singular resources/data sources, list data sources, stream history lookup, acceptance/unit tests, provider registration, and CI suite wiring.

Changes:

Adds linode_monitor_logs_destination and linode_monitor_logs_stream resources with schema, CRUD, model flattening, templates, and tests.
Adds singular/list data sources for destinations and streams, plus a stream history data source.
Registers the new Terraform types and adds their integration suites to the workflow.

Reviewed changes

Copilot reviewed 52 out of 52 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
`.github/workflows/integration_tests.yml`	Adds monitor logs suites and long-test env propagation.
`linode/framework_provider.go`	Registers new monitor logs resources and data sources.
`linode/monitorlogsdestination/framework_resource.go`	Implements destination resource CRUD.
`linode/monitorlogsdestination/framework_models.go`	Adds destination resource/data source models and flattening.
`linode/monitorlogsdestination/framework_schema_resource.go`	Defines destination resource schema.
`linode/monitorlogsdestination/framework_schema_datasource.go`	Defines singular destination data source schema.
`linode/monitorlogsdestination/framework_datasource.go`	Implements singular destination data source read.
`linode/monitorlogsdestination/framework_models_unit_test.go`	Adds destination model unit tests.
`linode/monitorlogsdestination/resource_test.go`	Adds destination resource acceptance tests.
`linode/monitorlogsdestination/datasource_test.go`	Adds destination data source acceptance tests.
`linode/monitorlogsdestination/tmpl/template.go`	Adds destination test template helpers.
`linode/monitorlogsdestination/tmpl/basic.gotf`	Adds destination basic resource test config.
`linode/monitorlogsdestination/tmpl/updates.gotf`	Adds destination update test config.
`linode/monitorlogsdestination/tmpl/bucket_only.gotf`	Adds bucket-only teardown config.
`linode/monitorlogsdestination/tmpl/data_basic.gotf`	Adds destination data source test config.
`linode/monitorlogsdestination/tmpl/data_not_found.gotf`	Adds destination not-found data source config.
`linode/monitorlogsdestination/tmpl/invalid_type.gotf`	Adds invalid destination type config.
`linode/monitorlogsdestinations/framework_datasource.go`	Implements list destination data source read/filtering.
`linode/monitorlogsdestinations/framework_models.go`	Adds list destination models.
`linode/monitorlogsdestinations/framework_schema_datasource.go`	Defines list destination data source schema/filter config.
`linode/monitorlogsdestinations/datasource_test.go`	Adds list destination data source acceptance test.
`linode/monitorlogsdestinations/tmpl/template.go`	Adds list destination test template helpers.
`linode/monitorlogsdestinations/tmpl/data_basic.gotf`	Adds list destination data source test config.
`linode/monitorlogsdestinations/tmpl/bucket_only.gotf`	Adds bucket-only teardown config.
`linode/monitorlogsstream/framework_resource.go`	Implements stream resource CRUD/import.
`linode/monitorlogsstream/framework_models.go`	Adds stream resource/data source models and options builders.
`linode/monitorlogsstream/framework_schema_resource.go`	Defines stream resource schema.
`linode/monitorlogsstream/framework_schema_datasource.go`	Defines singular stream data source schema.
`linode/monitorlogsstream/framework_datasource.go`	Implements singular stream data source read.
`linode/monitorlogsstream/framework_models_unit_test.go`	Adds stream model unit tests.
`linode/monitorlogsstream/resource_test.go`	Adds long-running stream lifecycle acceptance test and invalid config tests.
`linode/monitorlogsstream/datasource_test.go`	Adds stream data source not-found test.
`linode/monitorlogsstream/tmpl/template.go`	Adds stream test template helpers.
`linode/monitorlogsstream/tmpl/basic.gotf`	Adds stream basic resource test config.
`linode/monitorlogsstream/tmpl/lifecycle.gotf`	Adds stream lifecycle config covering related data sources.
`linode/monitorlogsstream/tmpl/updates.gotf`	Adds stream update config.
`linode/monitorlogsstream/tmpl/data_basic.gotf`	Adds singular stream data source config.
`linode/monitorlogsstream/tmpl/data_not_found.gotf`	Adds stream not-found data source config.
`linode/monitorlogsstream/tmpl/invalid_type.gotf`	Adds invalid stream type config.
`linode/monitorlogsstream/tmpl/invalid_destination.gotf`	Adds invalid destination config.
`linode/monitorlogsstreams/framework_datasource.go`	Implements list stream data source read/filtering.
`linode/monitorlogsstreams/framework_models.go`	Adds list stream models.
`linode/monitorlogsstreams/framework_schema_datasource.go`	Defines list stream data source schema/filter config.
`linode/monitorlogsstreams/datasource_test.go`	Adds skipped list stream data source test placeholder.
`linode/monitorlogsstreams/tmpl/template.go`	Adds list stream data source template helper.
`linode/monitorlogsstreams/tmpl/data_basic.gotf`	Adds list stream data source config.
`linode/monitorlogsstreamhistory/framework_datasource.go`	Implements stream history data source read.
`linode/monitorlogsstreamhistory/framework_models.go`	Adds stream history models and flattening.
`linode/monitorlogsstreamhistory/framework_schema_datasource.go`	Defines stream history data source schema.
`linode/monitorlogsstreamhistory/datasource_test.go`	Adds skipped stream history test placeholder.
`linode/monitorlogsstreamhistory/tmpl/template.go`	Adds stream history template helper.
`linode/monitorlogsstreamhistory/tmpl/data_basic.gotf`	Adds stream history data source config.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

yec-akamai

Can you add documentations for the new resources and data sources under /docs?

klipensk · 2026-06-03T12:12:39Z

added docs #2359 (review)

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

…orkflows

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Signed-off-by: sjerecze <sjerecze@akamai.com>

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

# Conflicts: # linode/framework_provider.go

Signed-off-by: sjerecze <sjerecze@akamai.com>

sjer-akamai · 2026-07-01T07:17:18Z

Rebased previous commits to clean up git history a bit and merged newest dev branch.

Signed-off-by: sjerecze <sjerecze@akamai.com>

psnoch-akamai · 2026-07-02T12:59:52Z

+	return detailsAttr.GetType().(types.ObjectType).AttrTypes
+}
+
+func TestFlattenStream_AuditLogs(t *testing.T) {


I got error for this test
./framework_models_unit_test.go:310:21: opts.Type undefined (type linodego.StreamUpdateOptions has no field or method Type). Could you verify it please?

Should be fixed

psnoch-akamai · 2026-07-02T13:01:04Z

+	"github.com/linode/terraform-provider-linode/v4/linode/monitorlogsstream/tmpl"
+)
+
+func TestAccDataSourceMonitorLogsStream_notFound(t *testing.T) {


I got error here
./resource_test.go:124:3: cannot use []string{…} (value of type []string) as []linodego.RegionCapability value in argument to acceptance.GetRandomRegionWithCaps ./resource_test.go:124:12: cannot use linodego.CapabilityObjectStorage (constant "Object Storage" of string type linodego.RegionCapability) as string value in array or slice literal

Should be fixed

Signed-off-by: sjerecze <sjerecze@akamai.com>

yec-akamai

Tests are all passing now. Thank you!

psnoch-akamai · 2026-07-07T12:54:42Z

+
+```terraform
+data "linode_monitor_logs_streams" "all" {}
+```


If there is empty list of streams, it returns error:
│ Error: Failed to list resources │ │ with data.linode_monitor_logs_destinations.test, │ on config.tf line 13, in data "linode_monitor_logs_destinations" "test": │ 13: data "linode_monitor_logs_destinations" "test" { │ │ [400] [X-Filter.+and] Cannot apply filter

The same output for empty destinations and data "linode_monitor_logs_destinations" "all" {}

This seems to be an API issue. Applied the same fix already present in listMonitorAlertChannels in repo, moving the filtering from API to terraform. Should work now

…d destinations list. Signed-off-by: sjerecze <sjerecze@akamai.com>

psnoch-akamai

Tested locally, works fine

klipensk requested review from a team as code owners May 25, 2026 09:28

klipensk requested review from psnoch-akamai and yec-akamai and removed request for a team May 25, 2026 09:28

sjer-akamai force-pushed the dev branch 2 times, most recently from 33d0b4a to a2f18a1 Compare May 25, 2026 14:00

yec-akamai requested a review from Copilot May 31, 2026 18:31

Copilot started reviewing on behalf of yec-akamai May 31, 2026 18:31 View session

Copilot AI reviewed May 31, 2026

View reviewed changes

Comment thread linode/framework_provider.go

Comment thread linode/monitorlogsstreams/datasource_test.go

Comment thread linode/monitorlogsstreamhistory/datasource_test.go

Comment thread linode/monitorlogsstream/framework_resource.go

yec-akamai reviewed Jun 2, 2026

View reviewed changes

Comment thread linode/monitorlogsdestination/framework_schema_resource.go Outdated

yec-akamai added community-contribution new-feature for new features in the changelog. labels Jun 2, 2026

klipensk requested a review from yec-akamai June 3, 2026 12:13

klipensk changed the title ~~[DPS-42656] [ACLP SDK][Terraform] ACLP Logs SDK Pull request~~ ACLP Logs SDK Pull request Jun 3, 2026

sjer-akamai force-pushed the dev branch 2 times, most recently from b3ca4ad to 4573e30 Compare June 25, 2026 07:06

GWrona and others added 11 commits June 25, 2026 09:45

[DPS-42280] [ACLP SDK] [Terraform] ACLP Logs destination API - draft

775b204

[DPS-42280] [ACLP SDK] [Terraform] ACLP Logs destination API - tests

10f5054

ACLP Logs - Destination integration tests tweaks + extend units

917457f

ACLP Logs - Add negative integration test cases

6c4d2b1

ACLP Logs - Stabilize tests - fix integration tests cleanup fails

2773a82

ACLP Logs - extend checkLogsDestinationDestroy assertion

b1bff69

ACLP Logs - stabilize tests - use explicit access keys for teardown

325840e

Apply suggestions from code review

7e7c57a

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

ACLP Logs - Review tweaks

567c6bb

[DPS-42282] [ACLP SDK] [Terraform] ACLP Logs Stream API

5b5d67f

[DPS-42282] [ACLP SDK] [Terraform] ACLP Logs Stream API

1d9fb2e

klipensk and others added 11 commits June 25, 2026 09:45

[DPS-42282] [ACLP SDK] [Terraform] ACLP Logs Stream API - ci and pr w…

1520c20

…orkflows

[DPS-42282] [ACLP SDK] [Terraform] ACLP Logs Stream API - pr fixes

ead6b95

[DPS-42282] [ACLP SDK] [Terraform] ACLP Logs Stream API - pr fixes

e9157aa

Potential fix for pull request finding

1ebb03a

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Potential fix for pull request finding

fb81679

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

ACLP Logs destination - fix unit tests

40ef1a6

Signed-off-by: sjerecze <sjerecze@akamai.com>

Potential fix for pull request finding

42fa9ed

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

[ACLP SDK][Terraform] ACLP Logs SDK Pull request - fixes

2da04c2

[ACLP SDK][Terraform] ACLP Logs SDK Pull request - workflow fixes

af035f0

Merge remote-tracking branch 'upstream/dev' into dev

3de83df

# Conflicts: # linode/framework_provider.go

ACLP Logs destination - Post dev merge fixes

a6eb291

Signed-off-by: sjerecze <sjerecze@akamai.com>

sjer-akamai force-pushed the dev branch from 4573e30 to a6eb291 Compare July 1, 2026 06:48

ACLP Logs - Fix unit tests after linodego update

0d00348

Signed-off-by: sjerecze <sjerecze@akamai.com>

psnoch-akamai reviewed Jul 2, 2026

View reviewed changes

ACLP Logs - Fix getRegionForStreamTest

d99e155

Signed-off-by: sjerecze <sjerecze@akamai.com>

yec-akamai approved these changes Jul 2, 2026

View reviewed changes

psnoch-akamai reviewed Jul 7, 2026

View reviewed changes

ACLP Logs - Fix filtering - disable api filtering for logs streams an…

29d2609

…d destinations list. Signed-off-by: sjerecze <sjerecze@akamai.com>

psnoch-akamai approved these changes Jul 7, 2026

View reviewed changes

yec-akamai merged commit 70a0110 into linode:dev Jul 7, 2026
9 checks passed

ezilber-akamai added project for new projects in the changelog. and removed new-feature for new features in the changelog. labels Jul 10, 2026

ezilber-akamai changed the title ~~ACLP Logs SDK Pull request~~ ACLP Logs Jul 10, 2026

Uh oh!

Conversation

klipensk commented May 25, 2026

📝 Description

✔️ How to Test

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

yec-akamai left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

klipensk commented Jun 3, 2026

Uh oh!

sjer-akamai commented Jul 1, 2026

Uh oh!

psnoch-akamai Jul 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sjer-akamai Jul 2, 2026

Choose a reason for hiding this comment

Uh oh!

psnoch-akamai Jul 2, 2026

Choose a reason for hiding this comment

Uh oh!

sjer-akamai Jul 2, 2026

Choose a reason for hiding this comment

Uh oh!

yec-akamai left a comment

Choose a reason for hiding this comment

Uh oh!

psnoch-akamai Jul 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sjer-akamai Jul 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

psnoch-akamai left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

psnoch-akamai Jul 2, 2026 •

edited

Loading

psnoch-akamai Jul 7, 2026 •

edited

Loading

sjer-akamai Jul 7, 2026 •

edited

Loading