Skip to content

Commit 91a9335

Browse files
committed
isobusfs: fix clang warnings
Fix following clang warnings: CC isobusfs/isobusfs_srv_fa.o isobusfs/isobusfs_srv_fa.c:387:6: warning: variable 'handle' is used uninitialized whenever 'if' condition is true [-Wsometimes-uninitialized] if (ret < 0) { ^~~~~~~ isobusfs/isobusfs_srv_fa.c:411:15: note: uninitialized use occurs here res.handle = handle; ^~~~~~ isobusfs/isobusfs_srv_fa.c:387:2: note: remove the 'if' if its condition is always false if (ret < 0) { ^~~~~~~~~~~~~~ isobusfs/isobusfs_srv_fa.c:368:6: warning: variable 'handle' is used uninitialized whenever 'if' condition is true [-Wsometimes-uninitialized] if (name_len > ISOBUSFS_MAX_PATH_NAME_LENGTH) { ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ isobusfs/isobusfs_srv_fa.c:411:15: note: uninitialized use occurs here res.handle = handle; ^~~~~~ isobusfs/isobusfs_srv_fa.c:368:2: note: remove the 'if' if its condition is always false if (name_len > ISOBUSFS_MAX_PATH_NAME_LENGTH) { ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ isobusfs/isobusfs_srv_fa.c:362:6: warning: variable 'handle' is used uninitialized whenever 'if' condition is true [-Wsometimes-uninitialized] if (name_len > msg->len - sizeof(*req)) { ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ isobusfs/isobusfs_srv_fa.c:411:15: note: uninitialized use occurs here res.handle = handle; ^~~~~~ isobusfs/isobusfs_srv_fa.c:362:2: note: remove the 'if' if its condition is always false if (name_len > msg->len - sizeof(*req)) { ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ isobusfs/isobusfs_srv_fa.c:356:6: warning: variable 'handle' is used uninitialized whenever 'if' condition is true [-Wsometimes-uninitialized] if (!client) { ^~~~~~~ isobusfs/isobusfs_srv_fa.c:411:15: note: uninitialized use occurs here res.handle = handle; ^~~~~~ isobusfs/isobusfs_srv_fa.c:356:2: note: remove the 'if' if its condition is always false if (!client) { ^~~~~~~~~~~~~~ isobusfs/isobusfs_srv_fa.c:352:16: note: initialize the variable 'handle' to silence this warning uint8_t handle; ^ = '\0' isobusfs/isobusfs_srv_fa.c:505:9: warning: variable 'entry_count' set but not used [-Wunused-but-set-variable] size_t entry_count = 0; ^ 5 warnings generated. Signed-off-by: Oleksij Rempel <linux@rempel-privat.de>
1 parent bbd48cb commit 91a9335

1 file changed

Lines changed: 1 addition & 5 deletions

File tree

isobusfs/isobusfs_srv_fa.c

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -348,8 +348,8 @@ static int isobusfs_srv_fa_open_file_req(struct isobusfs_srv_priv *priv,
348348
uint8_t error_code = 0;
349349
uint8_t access_type;
350350
size_t abs_path_len;
351+
uint8_t handle = 0;
351352
char *abs_path;
352-
uint8_t handle;
353353
int ret = 0;
354354

355355
client = isobusfs_srv_get_client_by_msg(priv, msg);
@@ -502,8 +502,6 @@ static int isobusfs_srv_read_directory(struct isobusfs_srv_handles *handle,
502502
DIR *dir = handle->dir;
503503
struct dirent *entry;
504504
size_t pos = 0;
505-
size_t entry_count = 0;
506-
507505

508506
/*
509507
* Position the directory stream to the previously stored offset (handle->dir_pos).
@@ -596,8 +594,6 @@ static int isobusfs_srv_read_directory(struct isobusfs_srv_handles *handle,
596594
size = htole32(file_stat.st_size);
597595
memcpy(buffer + pos, &size, sizeof(size));
598596
pos += sizeof(size);
599-
600-
entry_count++;
601597
}
602598

603599
*readed_size = pos;

0 commit comments

Comments
 (0)