Merge pull request #148 from linux-credentials/portal-api

Add Portal handler D-Bus interface

Author: iinuwa

.vscode/launch.json

@@ -11,9 +11,13 @@
             "program": "${workspaceFolder}/build/credentialsd/src/credentialsd",
             "args": [],
             "env": {
-                "RUST_LOG": "credentialsd=debug,libwebauthn=debug,libwebauthn::webauthn=debug,libwebauthn=warn,libwebauthn::proto::ctap2::preflight=debug,libwebauthn::transport::channel=debug,zbus::object_server::debug,zbus=debug"
+                "RUST_LOG": "credentialsd=debug,libwebauthn=debug,libwebauthn::webauthn=debug,libwebauthn=warn,libwebauthn::proto::ctap2::preflight=debug,libwebauthn::transport::channel=debug,zbus::object_server::debug,zbus=debug",
+                "CREDSD_TRUSTED_CALLERS": "/usr/bin/python3.14",
+                "CREDSD_TRUSTED_APP_IDS": "app:xyz.iinuwa.credentialsd.DemoCredentialsUi",
             },
-            "sourceLanguages": ["rust"],
+            "sourceLanguages": [
+                "rust"
+            ],
             "cwd": "${workspaceFolder}",
             "preLaunchTask": "Meson: Build Daemon"
         },
@@ -27,15 +31,20 @@
                 "GSETTINGS_SCHEMA_DIR": "${workspaceFolder}/build/credentialsd-ui/data",
                 "RUST_LOG": "credentialsd_ui=debug,zbus::trace,zbus::object_server::debug"
             },
-            "sourceLanguages": ["rust"],
+            "sourceLanguages": [
+                "rust"
+            ],
             "cwd": "${workspaceFolder}",
             "preLaunchTask": "Meson: Build UI"
         },
     ],
     "compounds": [
         {
             "name": "Server/Client",
-            "configurations": ["Debug UI (credentialsd-ui)", "Debug Daemon (credentialsd)"]
+            "configurations": [
+                "Debug UI (credentialsd-ui)",
+                "Debug Daemon (credentialsd)"
+            ]
         }
     ]
-}
+}

credentialsd-common/src/model.rs

@@ -10,6 +10,8 @@ pub struct Credential {
     pub username: Option<String>,
 }
 
+/// Client Capabilities, as defined in
+/// [WebAuthn](https://www.w3.org/TR/webauthn-3/#enumdef-clientcapability).
 #[derive(SerializeDict, Type)]
 #[zvariant(signature = "dict", rename_all = "camelCase")]
 pub struct GetClientCapabilitiesResponse {
@@ -110,7 +112,7 @@ pub struct RequestingApplication {
     /// The name of the application.
     pub name: Optional<String>,
 
-    /// The PID of the applicatoin
+    /// The PID of the application
     pub pid: u32,
 }
 

credentialsd-common/src/server.rs

@@ -1,6 +1,6 @@
 //! Types for serializing across D-Bus instances
 
-use std::fmt::Display;
+use std::{collections::HashMap, fmt::Display};
 
 use serde::{
     Deserialize, Serialize,
@@ -11,7 +11,7 @@ use zvariant::{
     SerializeDict, Signature, Structure, StructureBuilder, Type, Value, signature::Fields,
 };
 
-use crate::model::{BackgroundEvent, Device, Operation, RequestingApplication};
+use crate::model::{BackgroundEvent, Operation, RequestingApplication};
 
 const TAG_VALUE_SIGNATURE: &Signature = &Signature::Structure(Fields::Static {
     fields: &[&Signature::U8, &Signature::Variant],
@@ -113,6 +113,14 @@ pub struct CreateCredentialResponse {
     public_key: Option<CreatePublicKeyCredentialResponse>,
 }
 
+impl NoneValue for CreateCredentialResponse {
+    type NoneType = HashMap<String, OwnedValue>;
+
+    fn null_value() -> Self::NoneType {
+        HashMap::new()
+    }
+}
+
 #[derive(Clone, Debug, DeserializeDict, Type)]
 #[zvariant(signature = "dict")]
 pub struct CreatePublicKeyCredentialRequest {
@@ -197,8 +205,6 @@ impl TryFrom<&Value<'_>> for crate::model::Error {
 pub struct GetCredentialRequest {
     pub origin: Option<String>,
     pub is_same_origin: Option<bool>,
-    #[zvariant(rename = "type")]
-    pub r#type: String,
     #[zvariant(rename = "publicKey")]
     pub public_key: Option<GetPublicKeyCredentialRequest>,
 }