Apply some cargo clippy fixes

Author: iinuwa

xyz-iinuwa-credential-manager-portal-gtk/src/credential_service/hybrid.rs

@@ -55,6 +55,9 @@ impl HybridHandler for InternalHybridHandler {
                         panic!();
                     }
                 };
+                if let Err(err) = tx.send(HybridStateInternal::Connected).await {
+                    tracing::error!("Failed to send caBLE update: {:?}", err)
+                }
                 let response: AuthenticatorResponse = loop {
                     match &request {
                         CredentialRequest::CreatePublicKeyCredentialRequest(make_request) => {

xyz-iinuwa-credential-manager-portal-gtk/src/credential_service/server.rs

@@ -13,6 +13,7 @@ use super::hybrid::{HybridHandler, HybridState};
 use super::usb::{UsbHandler, UsbState};
 use super::CredentialService;
 
+#[allow(clippy::enum_variant_names)]
 pub enum ServiceRequest {
     GetDevices,
     GetHybridCredential,

xyz-iinuwa-credential-manager-portal-gtk/src/view_model/gtk/mod.rs

@@ -284,7 +284,8 @@ impl ViewModel {
                 todo!();
             }
         }
-        self.set_selected_device(&device.into());
+        let device_object: DeviceObject = device.into();
+        self.set_selected_device(device_object);
         self.set_selected_credential("");
     }
 

xyz-iinuwa-credential-manager-portal-gtk/src/view_model/mod.rs

@@ -7,7 +7,7 @@ use async_std::{
     channel::{Receiver, Sender},
     sync::Mutex,
 };
-use tokio::sync::{mpsc, oneshot};
+use tokio::sync::mpsc;
 use tracing::{error, info};
 
 use crate::credential_service::{CredentialServiceClient, UsbState};
@@ -152,7 +152,11 @@ impl<C: CredentialServiceClient + Send> ViewModel<C> {
                     todo!();
                 }
             };
-            self.selected_credential = None;
+            // Remove the attribute below when we implement cancellation for at least one transport.
+            #[allow(unreachable_code)]
+            {
+                self.selected_credential = None;
+            }
         }
 
         // start discovery for newly selected device
@@ -264,7 +268,7 @@ impl<C: CredentialServiceClient + Send> ViewModel<C> {
                 }
                 Event::View(ViewEvent::UsbPinEntered(pin)) => {
                     if let Some(pin_tx) = self.usb_pin_tx.take() {
-                        if let Err(_) = pin_tx.lock().await.send(pin).await {
+                        if pin_tx.lock().await.send(pin).await.is_err() {
                             error!("Failed to send pin to device");
                         }
                     }

xyz-iinuwa-credential-manager-portal-gtk/src/webauthn.rs

@@ -254,10 +254,10 @@ impl TryFrom<CredentialDescriptor> for Ctap2PublicKeyCredentialDescriptor {
 #[zvariant(signature = "dict")]
 /// https://www.w3.org/TR/webauthn-3/#dictionary-authenticatorSelection
 pub(crate) struct AuthenticatorSelectionCriteria {
-    /// https://www.w3.org/TR/webauthn-3/#enum-attachment
-    #[zvariant(rename = "authenticatorAttachment")]
-    pub authenticator_attachment: Option<String>,
-
+    // /// https://www.w3.org/TR/webauthn-3/#enum-attachment
+    // #[zvariant(rename = "authenticatorAttachment")]
+    // pub authenticator_attachment: Option<String>,
+    //
     /// https://www.w3.org/TR/webauthn-3/#enum-residentKeyRequirement
     #[zvariant(rename = "residentKey")]
     pub resident_key: Option<String>,