Revamp discovery#163
Draft
iinuwa wants to merge 2 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This shifts the responsibility of starting discovery on each "interface" (hybrid, USB, NFC, etc.) to the frontend rather than the backend. This way, the backend only needs to signal that they're ready for the credential, and the frontend listens on all the interfaces it can.
This means that the backend only needs to:
The UI could still show buttons to allow the user to make an explicit choice, e.g., if the backend decides to show the hybrid QR code as the primary screen for starting the flow, they can still show the "Use security key" button at the bottom as a secondary option. That would just be an aid to the user's understanding; it wouldn't affect the actual discovery.
Some design questions: