Conversation
Member
iinuwa
commented
May 25, 2025
- add GTK changes and QR code lib for UI flow
- Add handler trait and stream to pull into view model
- Add dummy hybrid QR handler for demonstrating flow
Member
|
LGTM so far (I tried running this) |
1b62327 to
b359bf4
Compare
Member
Author
|
This still needs a couple of things:
There's a weird race condition or something: the UI renders correctly if I add breakpoints, but misses the initial update. I'm wondering if this is some sort of problem with mixing async runtimes. To avoid a big rebase, I'm going to go ahead and merge this in, switch over to Tokio every, and then come back to this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.