Refactor transport modules#39
Merged
Merged
Conversation
Member
Author
|
Something screwy is going on with GitHub actions. Tests (as anemic as they are) still pass locally. Merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The biggest thing is that this splits the GUI thread from the thread that interacts with credentials to make it easier to use Tokio through out the background service, in hope of solving the USB PresenceRequired bug (#38).
That bug still exists, but it cleans up the USB and hybrid code interaction quite a bit and makes hybrid credentials work (just tested with Android). It also makes it a little bit easier to start writing test code.