Skip to content

Define security policy#93

Merged
iinuwa merged 4 commits into
mainfrom
security-policy
Aug 14, 2025
Merged

Define security policy#93
iinuwa merged 4 commits into
mainfrom
security-policy

Conversation

@iinuwa
Copy link
Copy Markdown
Member

@iinuwa iinuwa commented Aug 13, 2025

Closes #86

msirringhaus
msirringhaus previously approved these changes Aug 14, 2025
Copy link
Copy Markdown
Collaborator

@msirringhaus msirringhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but I'd recommend waiting for feedback from @AlfioEmanueleFresta, as I'm not well versed in these kind of statements

Comment thread SECURITY.md Outdated

Please note, that if you believe you have discovered a security problem outside
of this scope, we still want to know about it! We would still like to discuss
the issue privately, but we may not decide to address it within the response
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: word order "but we may decide not to address"?

Copy link
Copy Markdown
Member Author

@iinuwa iinuwa Aug 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, you're right, that's not what I intended to convey. I think it's even more clear to say:

Suggested change
the issue privately, but we may not decide to address it within the response
the issue privately, but we may decide to address it beyond the response

Copy link
Copy Markdown

@kalvdans kalvdans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great document to have, but please define all users of "we" a bit closer. I take it that potential vulnerabilities reports go to the github project maintainers, which individuals I believe is not open information. But since this in an open-source project, it is a broader group of collaborators that decides about features and scope of the project.

I've suggested some concrete changes, but I'm not a good text writer myself.

Comment thread SECURITY.md
Comment on lines +33 to +35
We only support the latest published release. We may backport patches when
possible to help users running on distributions that package older versions of
our software.
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
We only support the latest published release. We may backport patches when
possible to help users running on distributions that package older versions of
our software.
The security team only respond to reports about the latest published release.
Collaborators may backport patches when possible to help users running on distributions that package older versions of the software.

Comment thread SECURITY.md
you.

[new-advisory]: https://github.com/linux-credentials/credentialsd/security/advisories/new

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## Security Team
The security team consist of the github project maintainers, which list of indivuduals are kept closed and
might change over time.

Comment thread SECURITY.md Outdated
data), so those are out of scope.

[^2]:
In the future we may offer stricter configuration where privileged clients
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
In the future we may offer stricter configuration where privileged clients
In the future the service may offer stricter configuration where privileged clients

@iinuwa
Copy link
Copy Markdown
Member Author

iinuwa commented Aug 14, 2025

Great document to have, but please define all users of "we" a bit closer. I take it that potential vulnerabilities reports go to the github project maintainers, which individuals I believe is not open information. But since this in an open-source project, it is a broader group of collaborators that decides about features and scope of the project.

I've suggested some concrete changes, but I'm not a good text writer myself.

Thanks for the feedback, @kalvdans! I've clarified in the opening sentence that "we" refers to the project maintainers. While we accept contributions from the community, I think putting security responsibility on contributors wouldn't be fair since they don't have control over the code. I think it's important for the responsibility for features to be kept by those who have permission to merge and release the code, so I've kept the "we" language throughout. We'll take backports on a case-by-case basis.

Copy link
Copy Markdown
Member

@AlfioEmanueleFresta AlfioEmanueleFresta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Added a few comments, feel free to choose which, if any, to address.

Comment thread SECURITY.md Outdated
Comment thread SECURITY.md Outdated
Comment thread SECURITY.md
@iinuwa iinuwa merged commit 482e654 into main Aug 14, 2025
1 check passed
@iinuwa iinuwa deleted the security-policy branch August 14, 2025 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add SECURITY.md

4 participants