Refactor a bit#123
Merged
AlfioEmanueleFresta merged 3 commits intoJul 15, 2025
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the WebAuthn implementation by extracting core logic into smaller modules without changing functionality or the public API.
- Moved PIN/UV authentication logic into
pin_uv_auth_token.rs - Introduced an
error.rsto centralize error types for WebAuthn - Updated imports across many files to reference the new modules and removed duplicated code from
webauthn.rs
Reviewed Changes
Copilot reviewed 25 out of 25 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| libwebauthn/src/webauthn/pin_uv_auth_token.rs | New module for PIN/UV auth token handling |
| libwebauthn/src/webauthn/error.rs | Centralized WebAuthn errors (Error, PlatformError) |
| libwebauthn/src/webauthn.rs | Removed duplicated implementations and added module imports |
Multiple transport and management files |
Updated imports to use the new error and PIN/UV modules |
Comments suppressed due to low confidence (1)
libwebauthn/src/webauthn.rs:4
- The file uses
Durationin several method signatures but no longer importsstd::time::Duration. Please adduse std::time::Duration;at the top to ensure the code compiles.
use async_trait::async_trait;
AlfioEmanueleFresta
approved these changes
Jul 15, 2025
AlfioEmanueleFresta
left a comment
Member
There was a problem hiding this comment.
Thank you so much for your work @msirringhaus!
830647d
into
linux-credentials:master
3 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #13 and splits a few big files into smaller chunks for easier handling.
No functional changes, only copy&paste.
Should also not be an API-change.