Skip to content

fix(cable): return ConnectionFailed for both Terminated paths #222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AlfioEmanueleFresta merged 1 commit into from
May 19, 2026
+6 −2
Merged

fix(cable): return ConnectionFailed for both Terminated paths #222

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions libwebauthn/src/transport/cable/channel.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,9 +55,13 @@ impl CableChannel {
return Ok(());
}

// If already terminated, return error immediately
// If already terminated, return error immediately. Mirror the
// post-`changed()` branch below so that an early-terminated channel
// surfaces the same variant as one that terminates while we wait;
// the caller can't observe the timing difference and the asymmetry
// was accidental.
if *rx.borrow() == ConnectionState::Terminated {
return Err(Error::Transport(TransportError::ConnectionLost));
return Err(Error::Transport(TransportError::ConnectionFailed));
}

// Wait for state change
Expand Down
Loading