client/file: Pre-allocate Vecs

Author: bilelmoussaoui

client/src/file/api/legacy_keyring.rs

@@ -74,7 +74,7 @@ impl Keyring {
 
     fn read_items(self, decrypted: &[u8]) -> Result<Vec<UnlockedItem>, Error> {
         let mut cursor = Cursor::new(decrypted);
-        let mut items = Vec::new();
+        let mut items = Vec::with_capacity(self.item_count);
         for _ in 0..self.item_count {
             let display_name = Self::read_string(&mut cursor)?
                 .ok_or_else(|| io::Error::new(io::ErrorKind::InvalidInput, "empty item label"))?;

client/src/file/locked_keyring.rs

@@ -155,9 +155,10 @@ impl LockedKeyring {
             Ok(mut file) => {
                 #[cfg(feature = "tracing")]
                 tracing::debug!("Keyring file found, loading its content");
-                let mtime = file.metadata().await?.modified().ok();
+                let metadata = file.metadata().await?;
+                let mtime = metadata.modified().ok();
 
-                let mut content = Vec::new();
+                let mut content = Vec::with_capacity(metadata.len() as usize);
                 file.read_to_end(&mut content).await?;
 
                 let keyring = api::Keyring::try_from(content.as_slice())?;

client/src/file/unlocked_keyring.rs

@@ -111,7 +111,8 @@ impl UnlockedKeyring {
         path: impl AsRef<Path>,
         secret: Secret,
     ) -> Result<Self, Error> {
-        let mut content = Vec::new();
+        let metadata = file.metadata().await?;
+        let mut content = Vec::with_capacity(metadata.len() as usize);
         file.read_to_end(&mut content).await?;
 
         match api::Keyring::try_from(content.as_slice()) {