Get rid of local_test feature

As we fixed those tests and made them run on CI

Author: bilelmoussaoui

.github/workflows/CI.yml

@@ -69,10 +69,10 @@ jobs:
 
       - name: Test (native)
         run: |
-          cargo test --manifest-path ./client/Cargo.toml --no-default-features --features tokio --features native_crypto,local_tests
+          cargo test --manifest-path ./client/Cargo.toml --no-default-features --features tokio --features native_crypto
       - name: Test (OpenSSL)
         run: |
-          cargo test --manifest-path ./client/Cargo.toml --no-default-features --features tokio --features openssl_crypto,local_tests
+          cargo test --manifest-path ./client/Cargo.toml --no-default-features --features tokio --features openssl_crypto
 
       - name: Test Server (native)
         run: |

.github/workflows/coverage.yml

@@ -60,7 +60,7 @@ jobs:
             --package oo7 \
             --lib \
             --no-default-features \
-            --features "tracing,tokio,native_crypto,local_tests" \
+            --features "tracing,tokio,native_crypto" \
             --ignore-panics \
             --out Lcov \
             --output-dir coverage-raw
@@ -72,7 +72,7 @@ jobs:
             --package oo7 \
             --lib \
             --no-default-features \
-            --features "tracing,async-std,openssl_crypto,local_tests" \
+            --features "tracing,async-std,openssl_crypto" \
             --ignore-panics \
             --out Lcov \
             --output-dir coverage-raw

client/Cargo.toml

@@ -57,10 +57,7 @@ tokio = { workspace = true, features = ["macros", "rt-multi-thread"] }
 tracing-subscriber = { version = "0.3", features = ["env-filter", "fmt"] }
 
 [features]
-default = ["local_tests", "tokio", "native_crypto"]
-# Some tests requires a prompt to be displayed, which can't be easily
-# handled in CI unless we write a mock service. The feature allows to disabling those tests in CI
-local_tests = []
+default = ["tokio", "native_crypto"]
 # Enables unstable low-level API
 unstable = []
 async-std = [

client/src/dbus/collection.rs

@@ -255,7 +255,7 @@ impl<'a> Collection<'a> {
 }
 
 #[cfg(test)]
-#[cfg(all(feature = "tokio", feature = "local_tests"))]
+#[cfg(feature = "tokio")]
 mod tests {
     use std::collections::HashMap;
 

client/src/dbus/service.rs

@@ -226,7 +226,7 @@ impl<'a> Service<'a> {
 }
 
 #[cfg(test)]
-#[cfg(all(feature = "tokio", feature = "local_tests"))]
+#[cfg(feature = "tokio")]
 mod tests {
     use super::Service;