Run clippy on tests as well

Author: bilelmoussaoui

.github/workflows/CI.yml

@@ -94,11 +94,11 @@ jobs:
         with:
           components: clippy
       - name: Clippy workspace (default features)
-        run: cargo clippy --workspace -- -D warnings
+        run: cargo clippy --workspace --tests -- -D warnings
       - name: Clippy client (tracing / async-std / native crypto)
         run: cargo clippy -p oo7 --no-default-features --features tracing,async-std,native_crypto,schema -- -D warnings
       - name: Clippy client (tracing / tokio / OpenSSL)
-        run: cargo clippy -p oo7 --no-default-features --features tracing,tokio,openssl_crypto,schema -- -D warnings
+        run: cargo clippy -p oo7 --no-default-features --features tracing,tokio,openssl_crypto,schema --tests -- -D warnings
 
   meson:
     name: Meson

client/tests/file_unlocked_keyring.rs

@@ -410,7 +410,7 @@ async fn comprehensive_search_patterns() -> Result<(), Error> {
     let keyring = UnlockedKeyring::load(&keyring_path, strong_key()).await?;
 
     // Create diverse test data
-    let test_items = vec![
+    let test_items = [
         (
             "Email Password",
             vec![
@@ -596,7 +596,7 @@ async fn secret_types_handling() -> Result<(), Error> {
         .create_item(
             "Binary Secret",
             &[("type", "binary")],
-            Secret::blob(&[0x00, 0x01, 0x02, 0xFF]),
+            Secret::blob([0x00, 0x01, 0x02, 0xFF]),
             false,
         )
         .await?;

server/src/collection/tests.rs

@@ -574,7 +574,7 @@ async fn delete_locked_collection_with_prompt_impl(
     setup.server.set_prompter_type(prompter_type).await;
     let default_collection = setup.default_collection().await?;
 
-    setup.lock_collection(&default_collection).await?;
+    setup.lock_collection(default_collection).await?;
 
     assert!(
         default_collection.is_locked().await?,
@@ -636,7 +636,7 @@ async fn unlock_retry_impl(prompter_type: PrompterType) -> Result<(), Box<dyn st
         .create_item("Test Item", &[("app", "test")], &dbus_secret, false, None)
         .await?;
 
-    setup.lock_collection(&default_collection).await?;
+    setup.lock_collection(default_collection).await?;
 
     assert!(
         default_collection.is_locked().await?,

server/src/gnome/internal.rs

@@ -311,7 +311,7 @@ mod tests {
         // Lock the collection
         setup
             .service_api
-            .lock(&[collection_path.clone()], None)
+            .lock(std::slice::from_ref(&collection_path), None)
             .await?;
 
         // Verify it's locked
@@ -369,7 +369,7 @@ mod tests {
         // Verify the password was changed by locking and unlocking with new password
         setup
             .service_api
-            .lock(&[collection_path.clone()], None)
+            .lock(std::slice::from_ref(&collection_path), None)
             .await?;
         assert!(
             default_collection.is_locked().await?,
@@ -429,7 +429,7 @@ mod tests {
         // Verify the password was changed by locking and unlocking with new password
         setup
             .service_api
-            .lock(&[collection_path.clone()], None)
+            .lock(std::slice::from_ref(&collection_path), None)
             .await?;
         assert!(
             default_collection.is_locked().await?,
@@ -474,7 +474,7 @@ mod tests {
         // Lock the collection
         setup
             .service_api
-            .lock(&[collection_path.clone()], None)
+            .lock(std::slice::from_ref(&collection_path), None)
             .await?;
 
         // Verify it's locked before attempting unlock

server/src/item/tests.rs

@@ -417,7 +417,7 @@ async fn delete_locked_item_with_prompt_impl(
     let items = default_collection.items().await?;
     assert_eq!(items.len(), 1, "Should have one item");
 
-    setup.lock_collection(&default_collection).await?;
+    setup.lock_collection(default_collection).await?;
 
     assert!(item.is_locked().await?, "Item should be locked");
 

server/src/service/mod.rs

@@ -111,7 +111,7 @@ impl Service {
             {
                 // For p2p test connections, use a dummy sender since p2p connections
                 // don't have a bus to assign unique names
-                UniqueName::try_from(":p2p.test").unwrap().into()
+                UniqueName::try_from(":p2p.test").unwrap()
             }
             #[cfg(not(any(test, feature = "test-util")))]
             {

server/src/service/tests.rs

@@ -106,7 +106,8 @@ async fn get_secrets() -> Result<(), Box<dyn std::error::Error>> {
     let setup = TestServiceSetup::plain_session(true).await?;
 
     // Test with empty items list - edge case
-    let secrets = setup.service_api.secrets(&vec![], &setup.session).await?;
+    #[allow(clippy::mutable_key_type)]
+    let secrets = setup.service_api.secrets(&[], &setup.session).await?;
     assert!(
         secrets.is_empty(),
         "Should return empty secrets for empty items list"
@@ -125,6 +126,7 @@ async fn get_secrets() -> Result<(), Box<dyn std::error::Error>> {
 
     // Get secrets for both items
     let item_paths = vec![item1.clone(), item2.clone()];
+    #[allow(clippy::mutable_key_type)]
     let secrets = setup
         .service_api
         .secrets(&item_paths, &setup.session)
@@ -178,6 +180,7 @@ async fn get_secrets_multiple_collections() -> Result<(), Box<dyn std::error::Er
 
     // Get secrets for both items from different collections
     let item_paths = vec![item1.clone(), item2.clone()];
+    #[allow(clippy::mutable_key_type)]
     let secrets = setup
         .service_api
         .secrets(&item_paths, &setup.session)
@@ -399,6 +402,7 @@ async fn get_secrets_with_non_existent_items() -> Result<(), Box<dyn std::error:
 
     // Request secrets for both real and fake items
     let item_paths = vec![item1.clone(), fake_item];
+    #[allow(clippy::mutable_key_type)]
     let secrets = setup
         .service_api
         .secrets(&item_paths, &setup.session)

server/src/tests.rs

@@ -186,7 +186,7 @@ impl TestServiceSetup {
         let session = Arc::new(session);
 
         let aes_key =
-            oo7::Key::generate_aes_key(&client_private_key, &server_public_key.as_ref().unwrap())?;
+            oo7::Key::generate_aes_key(&client_private_key, server_public_key.as_ref().unwrap())?;
 
         let collections = service_api.collections().await?;
 
@@ -645,7 +645,6 @@ pub(crate) struct MockPrompterServicePlasma {
 }
 
 #[cfg(any(feature = "plasma_native_crypto", feature = "plasma_openssl_crypto"))]
-
 impl MockPrompterServicePlasma {
     pub fn new() -> Self {
         Self {
@@ -734,7 +733,7 @@ impl MockPrompterServicePlasma {
         let connection = connection.clone();
 
         // Reject case
-        if *self.should_accept.lock().await == false {
+        if !*self.should_accept.lock().await {
             tokio::spawn(async move {
                 tracing::debug!(
                     "MockPrompterServicePlasma: dismissing prompt for {}",