client/file: Rev the list before deleting broken items

Fixes the recently updated test panic.

Author: bilelmoussaoui

client/src/file/mod.rs

@@ -559,7 +559,7 @@ impl Keyring {
             }
         }
         let n_broken_items = broken_items.len();
-        for index in broken_items {
+        for index in broken_items.into_iter().rev() {
             keyring.items.remove(index);
         }
         drop(keyring);
@@ -848,8 +848,8 @@ mod tests {
         let keyring_path = v1_dir.join("default.keyring");
         fs::copy(&fixture_path, &keyring_path).await?;
 
-        // 1) Load with the correct password and add several valid items.
-        //    This ensures n_valid_items > n_broken_items that we'll add later.
+        // 1) Load with the correct password and add several valid items. This ensures
+        //    n_valid_items > n_broken_items that we'll add later.
         let keyring = Keyring::load(&keyring_path, Secret::blob("test")).await?;
         for i in 0..VALID_TO_ADD {
             keyring
@@ -896,7 +896,6 @@ mod tests {
         Ok(())
     }
 
-
     #[tokio::test]
     async fn change_secret() -> Result<(), Error> {
         let data_dir = tempdir()?;