Get rid of rand dependencies

Author: bilelmoussaoui

Cargo.lock

@@ -32,7 +32,7 @@ clap = { version = "4.5", features = [ "cargo", "derive" ] }
 futures-channel = "0.3"
 futures-lite = "2.6"
 futures-util = "0.3"
-num-bigint-dig = { version = "0.8", features = ["zeroize"] }
+num-bigint-dig = { version = "0.9", features = ["zeroize"] }
 oo7 = { path = "client", version = "0.6", default-features = false, features = ["unstable", "tracing"]}
 serde = { version = "1.0", features = ["derive"] }
 tokio = { version = "1.48", default-features = false }

Cargo.toml

@@ -20,10 +20,7 @@ async-io = { version = "2.6.0", optional = true }
 async-lock = { version = "3.4.2", optional = true }
 blocking = { version = "1.5.1", optional = true }
 cbc = { version = "0.1", features = ["zeroize"], optional = true }
-cipher = { version = "0.4", features = [
-    "rand_core",
-    "zeroize",
-], optional = true }
+cipher = { version = "0.4", features = ["zeroize"], optional = true }
 digest = { version = "0.10", optional = true }
 endi.workspace = true
 futures-lite = { workspace = true, optional = true }
@@ -37,7 +34,6 @@ num = "0.4.0"
 num-bigint-dig.workspace = true
 openssl = { version = "0.10", optional = true }
 pbkdf2 = { version = "0.12", optional = true }
-rand = { version = "0.9", default-features = false, features = ["thread_rng"] }
 serde.workspace = true
 serde_bytes = "0.11"
 sha2 = { version = "0.10", optional = true }

client/Cargo.toml

@@ -7,6 +7,7 @@ pub enum Error {
     PadError(cipher::inout::PadError),
     #[cfg(feature = "native_crypto")]
     UnpadError(cipher::block_padding::UnpadError),
+    Getrandom(getrandom::Error),
 }
 
 #[cfg(feature = "openssl_crypto")]
@@ -30,13 +31,20 @@ impl From<cipher::inout::PadError> for Error {
     }
 }
 
+impl From<getrandom::Error> for Error {
+    fn from(value: getrandom::Error) -> Self {
+        Self::Getrandom(value)
+    }
+}
+
 impl std::error::Error for Error {
     fn source(&self) -> Option<&(dyn std::error::Error + 'static)> {
         match self {
             #[cfg(feature = "openssl_crypto")]
             Self::Openssl(e) => Some(e),
             #[cfg(feature = "native_crypto")]
             Self::UnpadError(_) | Self::PadError(_) => None,
+            Self::Getrandom(_) => None,
         }
     }
 }
@@ -50,6 +58,7 @@ impl std::fmt::Display for Error {
             Self::UnpadError(e) => f.write_fmt(format_args!("Wrong padding error: {e}")),
             #[cfg(feature = "native_crypto")]
             Self::PadError(e) => f.write_fmt(format_args!("Wrong padding error: {e}")),
+            Self::Getrandom(e) => f.write_fmt(format_args!("Random number generation error: {e}")),
         }
     }
 }

client/src/crypto/error.rs

@@ -74,8 +74,9 @@ pub(crate) fn iv_len() -> usize {
 }
 
 pub(crate) fn generate_private_key() -> Result<Zeroizing<Vec<u8>>, super::Error> {
-    let generic_array = EncAlg::generate_key(cipher::rand_core::OsRng);
-    Ok(Zeroizing::new(generic_array.to_vec()))
+    let mut key = vec![0u8; EncAlg::key_size()];
+    getrandom::fill(&mut key)?;
+    Ok(Zeroizing::new(key))
 }
 
 pub(crate) fn generate_public_key(private_key: impl AsRef<[u8]>) -> Result<Vec<u8>, super::Error> {
@@ -116,7 +117,9 @@ pub(crate) fn generate_aes_key(
 }
 
 pub fn generate_iv() -> Result<Vec<u8>, super::Error> {
-    Ok(EncAlg::generate_iv(cipher::rand_core::OsRng).to_vec())
+    let mut iv = vec![0u8; EncAlg::iv_size()];
+    getrandom::fill(&mut iv)?;
+    Ok(iv)
 }
 
 pub(crate) fn mac_len() -> usize {