server: Wrap Service.connection inside an Arc#318
Merged
Conversation
And drop changes introduced in da99ffe Fixes error: called `Option::unwrap()` on a `None` value when accessing service.collection field.
Collaborator
Author
|
Actually wrapping the connection field inside an Arc is the solution. Otherwise we're setting the connection field only inside the cloned instance :) |
Collaborator
So you did test the changes this time or? :) |
Collaborator
Author
|
Yeah, tested everything, multiple times :) |
Collaborator
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And drop changes introduced in da99ffe
Fixes error: called
Option::unwrap()on aNonevalue when accessing Service.collection field.