server: kde plasma prompter support

[hsitter]

the prompter UI currently lives at
https://invent.kde.org/mart/ksecretprompter and hopefully will make its way into plasma 6.6 (scheduled for february 2026)

[bilelmoussaoui]

what are chances of mocking the plasma prompter like we have for gnome at https://github.com/bilelmoussaoui/oo7/blob/main/server/src/tests.rs#L210-L432? and we could potentially run the tests using first gnome prompter then the plasma one

[bilelmoussaoui]

Let me know if you need help pushing this forward, as i will be doing a new release the upcoming week or so :)

[hsitter]

Sorry, vacation got in the way ⛷️ 😄

[hsitter]

Alrighty. New revision:

• server now has four new features plasma, gnome_native_crypto, gnome_openssl_crypto, and gnome.
• plasma and gnome_native_crypto are enabled by default. plasma has runtime detection and may fall through to gnome (i.e. things remain working on older plasma versions too)
• disabling all "backends" will result in compilation errors
• a lot of the plasma init code has moved from the prompt module to the plasma module. into a new start function
• in_plasma_environment now uses oncelock with lazy init instead of oncecell. lazycell didn't compile here because it can't be shared between threads

one big open topic is testing still

[hsitter]

Now also includes a mock prompter for testing. I am not a 100% happy with how the diff looks right now, certainly is very noisy, but I guess it's a start.

There now is a prompters() function for tests that returns a vector of "Activators". The activators encapsulate what is necessary to activate a given prompter. e.g. force plasma detection on or off as necessary. The relevant tests now for-loop over those activators to run the same test for both prompters.

I've somewhat clumsily forked a MockPrompterServicePlasma from the gnome variant. We might want to refactor this a bit so we don't have to call the setters on both mocks. On the other hand there are only a handful of those calls anyway.

e.g.

https://github.com/bilelmoussaoui/oo7/blob/59a90ac4e7061f9804ad6d60ecb5eac9d24fbda3/server/src/collection/tests.rs#L693-L708

The static IS_PLASMA was reshuffled again and is now a thread local mutable so we can toggle plasma-behavior at runtime in tests. Looks a bit awkward.

[hsitter]

I've added some fmt fixes. Also I've renamed the features so we don't break backwards compatibility (and hopefully the CI actions pass :D): native_crypto and openssl_crypto now imply gnome

[bilelmoussaoui]

The CI is failing because of an update of zbus, please run cargo update and push that in a separate commit, it should unbreak the build at least.

[bilelmoussaoui]

almost there.

[bilelmoussaoui]

The CI is failing because of an update of zbus, please run cargo update and push that in a separate commit, it should unbreak the build at least.

Took care of that along with adding a gnome feature that disables everything gnome related

[hsitter]

All comments should be addressed.

Seems the gnome conditionals broke for the tests. I've fixed it in my commit for now.

[bilelmoussaoui]

otherwise lgtm

[bilelmoussaoui]

Will merge once the CI passes

[bilelmoussaoui]

Thanks a lot!

[hsitter]

Yay! Thank you for the reviews and patience 😃

[bilelmoussaoui]

@hsitter Hey there, it seems like the current tests never hit the "dismissed" code path, could you please add a test case / extend current one, to cover that? There is also a new PromptRole::ChangePassword but it is only used by some backward compatibility gnome-keyring specific interface for now, we might support that in the future as part of the secret service specification but that would need a lot more than just a test case. If you can cover that as part of the test already, that would be great as well.

https://linux-credentials.github.io/oo7/coverage/server/src/plasma/index.html might be useful.

[hsitter]

👍 It may take me a couple weeks to get to it though.

[bilelmoussaoui]

No worries at all, thanks a lot