Skip to content

Commit b55d339

Browse files
[spyre] Run spyre checks only on RHEL and Fedora
All Spyre checks are now gated by the RHEL and Fedora schemes Signed-off-by: Sahithi Ravindranath <Sahithi.Ravindranath@ibm.com>
1 parent 82cbb07 commit b55d339

2 files changed

Lines changed: 38 additions & 16 deletions

File tree

servicereportpkg/repair/plugins/spyre_repair.py

Lines changed: 16 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -333,17 +333,19 @@ def repair(self, plugin_obj, checks):
333333
elif vfio_device_permission_check.get_status() is False:
334334
self.fix_vfio_perm_check(plugin_obj, vfio_device_permission_check)
335335

336-
sos_package_check = check_dir["sos package"]
337-
if sos_package_check.get_status() is False:
338-
self.fix_sos_package(plugin_obj, sos_package_check)
339-
elif sos_package_check.get_status is None:
340-
sos_package_check.set_note(Notes.NOT_FIXABLE)
341-
342-
sos_config_check = check_dir["sos config"]
343-
# if sos package is not intalled, not much can be done
344-
if not sos_package_check.get_status():
345-
sos_config_check.set_note(Notes.NOT_FIXABLE)
346-
elif sos_config_check.get_status() is False:
347-
self.fix_sos_config(plugin_obj, sos_config_check)
348-
elif sos_config_check.get_status is None:
349-
sos_config_check.set_note(Notes.NOT_FIXABLE)
336+
if "sos package" in check_dir.keys():
337+
sos_package_check = check_dir["sos package"]
338+
if sos_package_check.get_status() is False:
339+
self.fix_sos_package(plugin_obj, sos_package_check)
340+
elif sos_package_check.get_status is None:
341+
sos_package_check.set_note(Notes.NOT_FIXABLE)
342+
343+
if "sos config" in check_dir.keys():
344+
sos_config_check = check_dir["sos config"]
345+
# if sos package is not intalled, not much can be done
346+
if not sos_package_check.get_status():
347+
sos_config_check.set_note(Notes.NOT_FIXABLE)
348+
elif sos_config_check.get_status() is False:
349+
self.fix_sos_config(plugin_obj, sos_config_check)
350+
elif sos_config_check.get_status is None:
351+
sos_config_check.set_note(Notes.NOT_FIXABLE)

servicereportpkg/validate/plugins/spyre.py

Lines changed: 22 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,13 +20,13 @@
2020
from servicereportpkg.utils import is_package_installed
2121
from servicereportpkg.check import ConfigurationFileCheck
2222
from servicereportpkg.utils import is_read_write_to_owner_group_users
23+
from servicereportpkg.validate.schemes.schemes import FedoraScheme, RHELScheme
2324

2425

25-
class Spyre(Plugin, Scheme):
26+
class Spyre(object):
2627
"""Spyre configuration checks"""
2728

2829
def __init__(self):
29-
Plugin.__init__(self)
3030
self.name = Spyre.__name__
3131
self.description = Spyre.__doc__
3232

@@ -290,6 +290,12 @@ def check_vfio_access_permission(self):
290290
perm_check.set_status(status)
291291
return perm_check
292292

293+
class SpyreSoS(Spyre):
294+
"""Spyre SoS configuration check"""
295+
296+
def __init__(self):
297+
Spyre.__init__(self)
298+
293299
def check_sos_package(self):
294300
"""sos package"""
295301

@@ -355,3 +361,17 @@ def check_sos_config(self):
355361

356362
sos_config_check.set_status(status)
357363
return sos_config_check
364+
365+
class SpyreFedora(SpyreSoS, Plugin, FedoraScheme):
366+
"""Spyre Fedora configuration checks"""
367+
368+
def __init__(self):
369+
Plugin.__init__(self)
370+
SpyreSoS.__init__(self)
371+
372+
class SpyreRHEL(SpyreSoS, Plugin, RHELScheme):
373+
"""Spyre RHEL configuration checks"""
374+
375+
def __init__(self):
376+
Plugin.__init__(self)
377+
SpyreSoS.__init__(self)

0 commit comments

Comments
 (0)