autotools: fix potential shell syntax errors in configure.ac#384
Open
taraxacum45e9a wants to merge 2 commits intolinux-rdma:masterfrom
Open
autotools: fix potential shell syntax errors in configure.ac#384taraxacum45e9a wants to merge 2 commits intolinux-rdma:masterfrom
taraxacum45e9a wants to merge 2 commits intolinux-rdma:masterfrom
Conversation
Signed-off-by: Shen Jiamin <shen_jiamin@comp.nus.edu.sg>
…ison Signed-off-by: Shen Jiamin <shen_jiamin@comp.nus.edu.sg>
taraxacum45e9a
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a potential shell script syntax error in
configure.acby adopting a more robust string comparison pattern for theHAVE_REG_DMABUF_MRcheck.The Problem
The existing check used a direct variable expansion:
if test $HAVE_REG_DMABUF_MR = yes; thenIf
$HAVE_REG_DMABUF_MRis empty or undefined, the shell evaluates the expression asif test = yes; then. This causes a "unary operator expected" error during the execution of the./configurescript, potentially halting the build process or leading to incorrect configuration states.The Fix
I have updated the conditional to use the defensive
"x$VAR" = "xyes"idiom.-n).