pyverbs: Store action refs to fix cleanup errors

Store strong references to action objects in DrRule and
DrActionDestAttr to prevent Python garbage collection while C-level
objects still reference them.

Signed-off-by: Shachar Kagan <skagan@nvidia.com>

Author: ShacharKagan

pyverbs/providers/mlx5/dr_action.pxd

@@ -43,6 +43,7 @@ cdef class DrActionPopVLan(DrAction):
 
 cdef class DrActionDestAttr(PyverbsCM):
     cdef DrAction dest
+    cdef DrAction reformat
     cdef dv.mlx5dv_dr_action_dest_attr *action_dest_attr
     cdef dv.mlx5dv_dr_action_dest_reformat *dest_reformat
 

pyverbs/providers/mlx5/dr_action.pyx

@@ -216,14 +216,15 @@ cdef class DrActionDestAttr(PyverbsCM):
         super().__init__()
         self.dest_reformat = NULL
         self.action_dest_attr = NULL
-        if action_type == mlx5dv_dr_action_dest_type.MLX5DV_DR_ACTION_DEST:
-            self.action_dest_attr = <dv.mlx5dv_dr_action_dest_attr *> calloc(
+        self.dest = dest
+        self.reformat = None
+        self.action_dest_attr = <dv.mlx5dv_dr_action_dest_attr *> calloc(
                 1, sizeof(dv.mlx5dv_dr_action_dest_attr))
-            if self.action_dest_attr == NULL:
-                raise PyverbsRDMAErrno('Memory allocation for DrActionDestAttr failed.')
-            self.action_dest_attr.type = action_type
+        if self.action_dest_attr == NULL:
+            raise PyverbsRDMAErrno('Memory allocation for DrActionDestAttr failed.')
+        self.action_dest_attr.type = action_type
+        if action_type == mlx5dv_dr_action_dest_type.MLX5DV_DR_ACTION_DEST:
             self.action_dest_attr.dest = dest.action
-            self.dest = dest
         elif action_type == mlx5dv_dr_action_dest_type.MLX5DV_DR_ACTION_DEST_REFORMAT:
             self.dest_reformat = <dv.mlx5dv_dr_action_dest_reformat *> calloc(
                 1, sizeof(dv.mlx5dv_dr_action_dest_reformat))
@@ -232,6 +233,7 @@ cdef class DrActionDestAttr(PyverbsCM):
             self.action_dest_attr.dest_reformat = self.dest_reformat
             self.action_dest_attr.dest_reformat.reformat = reformat.action
             self.action_dest_attr.dest_reformat.dest = dest.action
+            self.reformat = reformat
         else:
             raise PyverbsError('Unsupported action type is provided.')
 
@@ -248,6 +250,8 @@ cdef class DrActionDestAttr(PyverbsCM):
         if self.dest_reformat != NULL:
             free(self.dest_reformat)
             self.dest_reformat = NULL
+        self.dest = None
+        self.reformat = None
 
 
 cdef class DrActionDestArray(DrAction):
@@ -280,6 +284,11 @@ cdef class DrActionDestArray(DrAction):
             raise PyverbsRDMAErrno('DrActionDestArray creation failed.')
         free(ptr_list)
         domain.dr_actions.add(self)
+        for action in dest_actions:
+            temp_attr = <DrActionDestAttr>action
+            temp_attr.dest.add_ref(self)
+            if temp_attr.reformat:
+                temp_attr.reformat.add_ref(self)
 
     def __dealloc__(self):
         self.close()

pyverbs/providers/mlx5/dr_rule.pxd

@@ -9,3 +9,4 @@ from pyverbs.base cimport PyverbsCM
 cdef class DrRule(PyverbsCM):
     cdef dv.mlx5dv_dr_rule *rule
     cdef object dr_matcher
+    cdef object actions

pyverbs/providers/mlx5/dr_rule.pyx

@@ -35,6 +35,7 @@ cdef class DrRule(PyverbsCM):
             raise PyverbsRDMAErrno('DrRule creation failed.')
         for i in range(0, len(actions)):
             (<DrAction>actions[i]).add_ref(self)
+        self.actions = actions
         matcher.add_ref(self)
         self.dr_matcher = matcher
 
@@ -50,3 +51,4 @@ cdef class DrRule(PyverbsCM):
                 raise PyverbsRDMAError('Failed to destroy DrRule.', rc)
             self.rule = NULL
             self.dr_matcher = None
+            self.actions = None