Skip to content

Commit e6632c2

Browse files
committed
Convert enums to constants for compatibility with C++20
1 parent 2241546 commit e6632c2

2 files changed

Lines changed: 47 additions & 57 deletions

File tree

libibverbs/verbs.h

Lines changed: 46 additions & 56 deletions
Original file line numberDiff line numberDiff line change
@@ -544,49 +544,41 @@ enum {
544544
IBV_WC_IP_CSUM_OK_SHIFT = 2
545545
};
546546

547-
enum ibv_create_cq_wc_flags {
548-
IBV_WC_EX_WITH_BYTE_LEN = 1 << 0,
549-
IBV_WC_EX_WITH_IMM = 1 << 1,
550-
IBV_WC_EX_WITH_QP_NUM = 1 << 2,
551-
IBV_WC_EX_WITH_SRC_QP = 1 << 3,
552-
IBV_WC_EX_WITH_SLID = 1 << 4,
553-
IBV_WC_EX_WITH_SL = 1 << 5,
554-
IBV_WC_EX_WITH_DLID_PATH_BITS = 1 << 6,
555-
IBV_WC_EX_WITH_COMPLETION_TIMESTAMP = 1 << 7,
556-
IBV_WC_EX_WITH_CVLAN = 1 << 8,
557-
IBV_WC_EX_WITH_FLOW_TAG = 1 << 9,
558-
IBV_WC_EX_WITH_TM_INFO = 1 << 10,
559-
IBV_WC_EX_WITH_COMPLETION_TIMESTAMP_WALLCLOCK = 1 << 11,
560-
};
561-
562-
enum {
563-
IBV_WC_STANDARD_FLAGS = IBV_WC_EX_WITH_BYTE_LEN |
564-
IBV_WC_EX_WITH_IMM |
565-
IBV_WC_EX_WITH_QP_NUM |
566-
IBV_WC_EX_WITH_SRC_QP |
567-
IBV_WC_EX_WITH_SLID |
568-
IBV_WC_EX_WITH_SL |
569-
IBV_WC_EX_WITH_DLID_PATH_BITS
570-
};
571-
572-
enum {
573-
IBV_CREATE_CQ_SUP_WC_FLAGS = IBV_WC_STANDARD_FLAGS |
574-
IBV_WC_EX_WITH_COMPLETION_TIMESTAMP |
575-
IBV_WC_EX_WITH_CVLAN |
576-
IBV_WC_EX_WITH_FLOW_TAG |
577-
IBV_WC_EX_WITH_TM_INFO |
578-
IBV_WC_EX_WITH_COMPLETION_TIMESTAMP_WALLCLOCK
579-
};
580-
581-
enum ibv_wc_flags {
582-
IBV_WC_GRH = 1 << 0,
583-
IBV_WC_WITH_IMM = 1 << 1,
584-
IBV_WC_IP_CSUM_OK = 1 << IBV_WC_IP_CSUM_OK_SHIFT,
585-
IBV_WC_WITH_INV = 1 << 3,
586-
IBV_WC_TM_SYNC_REQ = 1 << 4,
587-
IBV_WC_TM_MATCH = 1 << 5,
588-
IBV_WC_TM_DATA_VALID = 1 << 6,
589-
};
547+
static const uint32_t IBV_WC_EX_WITH_BYTE_LEN = 1 << 0;
548+
static const uint32_t IBV_WC_EX_WITH_IMM = 1 << 1;
549+
static const uint32_t IBV_WC_EX_WITH_QP_NUM = 1 << 2;
550+
static const uint32_t IBV_WC_EX_WITH_SRC_QP = 1 << 3;
551+
static const uint32_t IBV_WC_EX_WITH_SLID = 1 << 4;
552+
static const uint32_t IBV_WC_EX_WITH_SL = 1 << 5;
553+
static const uint32_t IBV_WC_EX_WITH_DLID_PATH_BITS = 1 << 6;
554+
static const uint32_t IBV_WC_EX_WITH_COMPLETION_TIMESTAMP = 1 << 7;
555+
static const uint32_t IBV_WC_EX_WITH_CVLAN = 1 << 8;
556+
static const uint32_t IBV_WC_EX_WITH_FLOW_TAG = 1 << 9;
557+
static const uint32_t IBV_WC_EX_WITH_TM_INFO = 1 << 10;
558+
static const uint32_t IBV_WC_EX_WITH_COMPLETION_TIMESTAMP_WALLCLOCK = 1 << 11;
559+
560+
static const uint32_t IBV_WC_STANDARD_FLAGS = IBV_WC_EX_WITH_BYTE_LEN |
561+
IBV_WC_EX_WITH_IMM |
562+
IBV_WC_EX_WITH_QP_NUM |
563+
IBV_WC_EX_WITH_SRC_QP |
564+
IBV_WC_EX_WITH_SLID |
565+
IBV_WC_EX_WITH_SL |
566+
IBV_WC_EX_WITH_DLID_PATH_BITS;
567+
568+
static const uint32_t IBV_CREATE_CQ_SUP_WC_FLAGS = IBV_WC_STANDARD_FLAGS |
569+
IBV_WC_EX_WITH_COMPLETION_TIMESTAMP |
570+
IBV_WC_EX_WITH_CVLAN |
571+
IBV_WC_EX_WITH_FLOW_TAG |
572+
IBV_WC_EX_WITH_TM_INFO |
573+
IBV_WC_EX_WITH_COMPLETION_TIMESTAMP_WALLCLOCK;
574+
575+
static const uint32_t IBV_WC_GRH = 1 << 0;
576+
static const uint32_t IBV_WC_WITH_IMM = 1 << 1;
577+
static const uint32_t IBV_WC_IP_CSUM_OK = 1 << IBV_WC_IP_CSUM_OK_SHIFT;
578+
static const uint32_t IBV_WC_WITH_INV = 1 << 3;
579+
static const uint32_t IBV_WC_TM_SYNC_REQ = 1 << 4;
580+
static const uint32_t IBV_WC_TM_MATCH = 1 << 5;
581+
static const uint32_t IBV_WC_TM_DATA_VALID = 1 << 6;
590582

591583
struct ibv_wc {
592584
uint64_t wr_id;
@@ -610,19 +602,17 @@ struct ibv_wc {
610602
uint8_t dlid_path_bits;
611603
};
612604

613-
enum ibv_access_flags {
614-
IBV_ACCESS_LOCAL_WRITE = 1,
615-
IBV_ACCESS_REMOTE_WRITE = (1<<1),
616-
IBV_ACCESS_REMOTE_READ = (1<<2),
617-
IBV_ACCESS_REMOTE_ATOMIC = (1<<3),
618-
IBV_ACCESS_MW_BIND = (1<<4),
619-
IBV_ACCESS_ZERO_BASED = (1<<5),
620-
IBV_ACCESS_ON_DEMAND = (1<<6),
621-
IBV_ACCESS_HUGETLB = (1<<7),
622-
IBV_ACCESS_FLUSH_GLOBAL = (1 << 8),
623-
IBV_ACCESS_FLUSH_PERSISTENT = (1 << 9),
624-
IBV_ACCESS_RELAXED_ORDERING = IBV_ACCESS_OPTIONAL_FIRST,
625-
};
605+
static const uint32_t IBV_ACCESS_LOCAL_WRITE = 1;
606+
static const uint32_t IBV_ACCESS_REMOTE_WRITE = (1<<1);
607+
static const uint32_t IBV_ACCESS_REMOTE_READ = (1<<2);
608+
static const uint32_t IBV_ACCESS_REMOTE_ATOMIC = (1<<3);
609+
static const uint32_t IBV_ACCESS_MW_BIND = (1<<4);
610+
static const uint32_t IBV_ACCESS_ZERO_BASED = (1<<5);
611+
static const uint32_t IBV_ACCESS_ON_DEMAND = (1<<6);
612+
static const uint32_t IBV_ACCESS_HUGETLB = (1<<7);
613+
static const uint32_t IBV_ACCESS_FLUSH_GLOBAL = (1 << 8);
614+
static const uint32_t IBV_ACCESS_FLUSH_PERSISTENT = (1 << 9);
615+
static const uint32_t IBV_ACCESS_RELAXED_ORDERING = IBV_ACCESS_OPTIONAL_FIRST;
626616

627617
struct ibv_mw_bind_info {
628618
struct ibv_mr *mr;

providers/mlx5/verbs.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -640,7 +640,7 @@ struct ibv_mr *mlx5_reg_mr(struct ibv_pd *pd, void *addr, size_t length,
640640
struct mlx5_mr *mr;
641641
struct ibv_reg_mr cmd;
642642
int ret;
643-
enum ibv_access_flags access = (enum ibv_access_flags)acc;
643+
uint32_t access = acc;
644644
struct ib_uverbs_reg_mr_resp resp;
645645

646646
mr = calloc(1, sizeof(*mr));

0 commit comments

Comments
 (0)