infiniband-diags: Add build_dr_path_to_lid and use it in iblinkinfo#1755
Open
mazorasaf wants to merge 1 commit into
Open
infiniband-diags: Add build_dr_path_to_lid and use it in iblinkinfo#1755mazorasaf wants to merge 1 commit into
mazorasaf wants to merge 1 commit into
Conversation
Member
|
Everything is wrong with this commit. Please review your AI generated code before submitting to rdma-core. As a beginning, nothing in the rdma-core code calls to your newly internally added build_dr_path_to_lid() function. Thanks |
Add build_dr_path_to_lid() to the ibdiags_tools library so all infiniband-diags tools can build a direct route (DR) path to a destination LID. It follows switch Linear Forwarding Tables via live SMP queries. This is needed for XDR: SMP via LID is not guaranteed to work in XDR fabrics, so utilities must be able to build and walk a direct route to reach a destination LID. Use it in iblinkinfo: when a start point is given via -S/-G, resolve the GUID to a LID and build a DR path to it so the partial scan starts from a DR-addressed portid instead of relying on LID routing. Signed-off-by: Asaf Mazor <amazor@nvidia.com>
mazorasaf
changed the title
Contributor
Author
|
Fixed.. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add build_dr_path_to_lid() to the ibdiags_tools library so all
infiniband-diags tools can build a direct route (DR) path to a
destination LID. It follows switch Linear Forwarding Tables via live
SMP queries.
This is needed for XDR: SMP via LID is not guaranteed to work in XDR
fabrics, so utilities must be able to build and walk a direct route to
reach a destination LID.
Use it in iblinkinfo: when a start point is given via -S/-G, resolve the
GUID to a LID and build a DR path to it so the partial scan starts from a
DR-addressed portid instead of relying on LID routing.