test: ensure role gathers the facts it uses by having test clear_facts before include_role

[richm]

The role gathers the facts it uses. For example, if the user uses
ANSIBLE_GATHERING=explicit, the role uses the setup module with the
facts and subsets it requires.

This change allows us to test this. Before every role invocation, the test
will use meta: clear_facts so that the role starts with no facts.

Create a task file tests/tasks/run_role_with_clear_facts.yml to do the tasks
to clear the facts and run the role. Note that this means we don't need to
use gather_facts for the tests.

Some vars defined using ansible_facts have been changed to be defined with
set_fact instead. This is because of the fact that vars are lazily
evaluated - the var might be referenced when the facts have been cleared, and
will issue an error like ansible_facts["distribution"] is undefined. This is
typically done for blocks that have a when condition that uses ansible_facts
and the block has a role invocation using run_role_with_clear_facts.yml
These have been rewritten to define the when condition using set_fact. This
is because the when condition is evaluated every time a task is invoked in the
block, and if the facts are cleared, this will raise an undefined variable error.

Signed-off-by: Rich Megginson rmeggins@redhat.com

Summary by Sourcery

Ensure crypto_policies role tests clear Ansible facts before each role invocation and centralize role execution into a reusable task file.

Tests:

• Replace direct linux-system-roles.crypto_policies role inclusions in tests with a shared task file that clears facts then runs the role.
• Stop gathering facts explicitly in tests that now rely on the shared clear-facts runner task.

[sourcery-ai]

Reviewer's Guide

Refactors tests to invoke the crypto_policies role through a new helper task file that clears Ansible facts before each role run, and introduces logic to optionally ignore role failures, ensuring the role under test gathers all facts it depends on rather than relying on pre-gathered facts.

File-Level Changes

Change	Details	Files
Introduce helper task file to clear facts and run the crypto_policies role with optional failure ignoring.	Add tests/tasks/run_role_with_clear_facts.yml that first runs meta: clear_facts, then includes the linux-system-roles.crypto_policies role Support optional parameters __sr_tasks_from, __sr_public, and __sr_failed_when to control which role tasks run, variable visibility, and failure handling Implement a block/rescue pattern to simulate include_role failed_when: false by swallowing role failures when __sr_failed_when is false, while providing a normal role run path when failures should propagate	tests/tasks/run_role_with_clear_facts.yml
Update existing tests to use the new helper instead of including the role directly and to avoid relying on implicit fact gathering.	Replace include_role: linux-system-roles.crypto_policies with include_tasks: tasks/run_role_with_clear_facts.yml in multiple test playbooks so each role run starts from cleared facts Adjust tests that previously used roles: linux-system-roles.crypto_policies to instead call the helper via a task, centralizing role invocation semantics Remove explicit gather_facts settings where no longer needed because the helper clears facts and lets the role gather what it needs	tests/tests_update.yml tests/tests_reload.yml tests/tests_bootc_e2e.yml tests/tests_default.yml tests/tests_reboot.yml tests/tests_no_package_update.yml tests/tests_include_vars_from_parent.yml

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[richm]

[citest]

[sourcery-ai]

Hey - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}