ci: ansible-lint requires dependencies to be installed [citest_skip]

[richm]

ansible-lint requires the dependencies in meta/collection-requirements.yml
and tests/collection-requirements.yml to be installed. tox-lsr 3.18.1
will ensure they are installed.

Refactor the tests somewhat so that the collection and test steps are separate.

Signed-off-by: Rich Megginson rmeggins@redhat.com

Summary by Sourcery

Update CI workflows to use the latest tox-lsr and separate Ansible collection conversion from lint and test execution.

CI:

• Bump tox-lsr to version 3.18.1 across Ansible-related GitHub Actions workflows.
• Split collection conversion into its own tox step before running ansible-lint and ansible-test jobs in CI.

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates CI workflows to use tox-lsr 3.18.1 and refactors ansible-lint and ansible-test jobs so that collection conversion runs in a separate tox environment from linting/testing.

File-Level Changes

Change	Details	Files
Bump tox-lsr dependency version in all relevant GitHub Actions workflows.	Update pip install commands to reference tox-lsr version 3.18.1 instead of 3.18.0 for CI workflows. Ensure ansible-lint, ansible-test, ansible-managed-var-comment, and qemu-kvm-integration-tests workflows all use the same tox-lsr version.	.github/workflows/ansible-lint.yml .github/workflows/ansible-test.yml .github/workflows/ansible-managed-var-comment.yml .github/workflows/qemu-kvm-integration-tests.yml
Refactor ansible-lint workflow to separate collection conversion from lint execution.	Split the single job step that ran both collection conversion and ansible-lint into two distinct steps. Add a dedicated step that runs tox -e collection to perform the role-to-collection conversion. Modify ansible-lint step to only run the ansible-lint tox environment, keeping environment overrides for ansible-lint and ansible-core versions and the basepython override.	.github/workflows/ansible-lint.yml
Refactor ansible-test workflow to separate collection conversion from ansible-test execution.	Split the combined step into a conversion step and a test step for clarity and dependency handling. Add a standalone tox -e collection step before running ansible-test. Adjust ansible-test tox invocation so it only runs the ansible-test environment with the appropriate basepython override, no longer chaining the collection env in the same tox call.	.github/workflows/ansible-test.yml

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've left some high level feedback:

• Now that multiple workflows pin tox-lsr to 3.18.1, consider defining this version once (e.g., as a workflow env var or reusable workflow input) to avoid future drift when bumping it again.
• You split collection and ansible-lint/ansible-test into separate steps, but only the latter still use set -euxo pipefail; if you want consistent failure behavior, consider adding similar shell options to the new Convert role to collection format steps as well.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- Now that multiple workflows pin `tox-lsr` to 3.18.1, consider defining this version once (e.g., as a workflow env var or reusable workflow input) to avoid future drift when bumping it again.
- You split `collection` and `ansible-lint`/`ansible-test` into separate steps, but only the latter still use `set -euxo pipefail`; if you want consistent failure behavior, consider adding similar shell options to the new `Convert role to collection format` steps as well.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}