refactor: comply with Ansible partner certification checks

comply with Ansible partner certification checks

Ansible is deprecating ansible six, so replace the functionality
we use with our own lsr_string_types

Add ansible-test sanity ignores for the milestone version

Signed-off-by: Rich Megginson <rmeggins@redhat.com>

Author: richm

.ansible/.lock

@@ -0,0 +1,2 @@
+plugins/modules/firewall_lib.py validate-modules:missing-gplv3-license
+plugins/modules/firewall_lib_facts.py validate-modules:missing-gplv3-license

.sanity-ansible-ignore-2.21.txt

@@ -583,11 +583,17 @@
     export_config_dict,
     recursive_show_diffs,
 )
-from ansible.module_utils.six import string_types
 import re
 import os
 import copy
 
+# ansible six is deprecated, and it seems a lot to add a dependency on python-six
+# just for this
+try:
+    lsr_string_types = basestring,
+except NameError:
+    lsr_string_types = str,
+    
 try:
     import ipaddress
 
@@ -738,7 +744,7 @@ def get_ipset_entries_type(ipset_entries, module):
 # ipset options values must be strings
 def normalize_ipset_options(ipset_options):
     for option, value in ipset_options.items():
-        if value is not None and not isinstance(value, string_types):
+        if value is not None and not isinstance(value, lsr_string_types):
             ipset_options[option] = str(value)
 
 
@@ -2766,7 +2772,7 @@ def parse_forward_port(module, item):
         else:
             _to_port = None
         _to_addr = item.get("toaddr")
-    elif isinstance(item, string_types):
+    elif isinstance(item, lsr_string_types):
         args = item.split(";")
         if len(args) == 3:
             __port, _to_port, _to_addr = args