ci: tox-lsr 3.17.0 - container test improvements, use ansible 2.20 for fedora 43 [citest_skip]

[richm]

tox-lsr 3.17.0 has some container test improvements - better output, faster runs

Use Ansible 2.20 for qemu/container tests on fedora 43

Signed-off-by: Rich Megginson rmeggins@redhat.com

Summary by Sourcery

Update CI workflows to use tox-lsr 3.17.0 and Ansible 2.20 for Fedora 43 test scenarios, improving container test performance and output.

CI:

• Bump tox-lsr from 3.16.0 to 3.17.0 across GitHub Actions workflows.
• Switch Fedora 43 qemu and container test scenarios to use Ansible 2.20 instead of 2.19.
• Adjust container test job environment to reuse requirements and callback plugins after the first test run for faster, cleaner executions.

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates CI workflows to use tox-lsr 3.17.0 and Ansible 2.20 for Fedora 43-based qemu/container tests, and adjusts container test environment variables to leverage new tox-lsr behavior for faster, clearer runs.

Sequence diagram for GitHub Actions container tests with tox_lsr_3_17_0 and Ansible_2_20

sequenceDiagram
  actor Dev as Developer
  participant GH as GitHub_Actions
  participant WF as CI_workflow_job
  participant Tox as tox
  participant TL as tox_lsr_3_17_0
  participant C as Fedora_43_container
  participant A as Ansible_2_20

  Dev->>GH: Push_commit_or_open_PR
  GH->>WF: Start_ansible_or_qemu_container_job

  WF->>WF: pip_install_tox_lsr_3_17_0
  WF->>Tox: Invoke_tox_with_env_for_container_tests
  Tox->>TL: Load_tox_lsr_plugin

  TL->>C: Start_container_with_updated_env
  C->>A: Run_ansible_tests_version_2_20
  A-->>C: Report_test_results

  C-->>TL: Container_logs_and_status
  TL-->>Tox: Aggregated_test_output
  Tox-->>WF: Overall_test_status
  WF-->>GH: Job_status_and_logs
  GH-->>Dev: CI_status_checks

Loading

File-Level Changes

Change	Details	Files
Bump tox-lsr dependency from 3.16.0 to 3.17.0 across GitHub Actions workflows.	Update pip install command in qemu-kvm-integration-tests workflow to use tox-lsr 3.17.0. Update ansible-lint workflow to install tox-lsr 3.17.0. Update ansible-managed-var-comment workflow to install tox-lsr 3.17.0. Update ansible-test workflow to install tox-lsr 3.17.0. Update python-unit-test workflow to install tox-lsr 3.17.0.	.github/workflows/qemu-kvm-integration-tests.yml .github/workflows/ansible-lint.yml .github/workflows/ansible-managed-var-comment.yml .github/workflows/ansible-test.yml .github/workflows/python-unit-test.yml
Update Fedora 43 matrix entries to use Ansible Core 2.20 for qemu and container tests.	Change qemu Fedora 43 matrix entry to use qemu-ansible-core-2-20. Change container Fedora 43 matrix entry to use container-ansible-core-2-20. Change container Fedora 43 bootc matrix entry to use container-ansible-core-2-20.	.github/workflows/qemu-kvm-integration-tests.yml
Adjust container test loop to use new tox-lsr-controlled SKIP_* flags for faster subsequent test runs.	Remove LSR_CONTAINER_PROFILE and LSR_CONTAINER_PRETTY overrides from container test step. Initialize SKIP_REQUIREMENTS and SKIP_CALLBACK_PLUGINS to false before the first tox run to ensure full setup. Set SKIP_REQUIREMENTS and SKIP_CALLBACK_PLUGINS to true after each test iteration so subsequent runs can skip requirements installation and callback plugin setup.	.github/workflows/qemu-kvm-integration-tests.yml

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've left some high level feedback:

• Consider centralizing the tox-lsr version (e.g., in a reusable workflow, action, or env variable) so it doesn’t need to be updated in multiple workflow files each time it changes.
• The new SKIP_REQUIREMENTS/SKIP_CALLBACK_PLUGINS toggling relies on implicit defaults; adding a brief comment or explicit initial unset/values before the loop could make the intended behavior clearer and less error‑prone for future changes.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- Consider centralizing the tox-lsr version (e.g., in a reusable workflow, action, or env variable) so it doesn’t need to be updated in multiple workflow files each time it changes.
- The new SKIP_REQUIREMENTS/SKIP_CALLBACK_PLUGINS toggling relies on implicit defaults; adding a brief comment or explicit initial unset/values before the loop could make the intended behavior clearer and less error‑prone for future changes.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}