ci: tox-lsr 3.16.0 - fix qemu tox test failures - rename to qemu-ansible-core-X-Y [citest_skip]

[richm]

the latest version of tox 4.49 has a strange issue - it thinks that a tox testenv
like [qemu-ansible-core-2.20] is specifying python 2.20 which conflicts with the
testenv basepython of python 3.latest. There appears to be no way to workaround this.

So, rename all of the testenvs to use major-minor instead of major.minor e.g.
[qemu-ansible-core-2-20]

Signed-off-by: Rich Megginson rmeggins@redhat.com

Summary by Sourcery

Update CI tox-lsr version and align qemu/container tox environment names with the new ansible-core naming convention.

CI:

• Bump tox-lsr used in GitHub workflows from 3.15.0 to 3.16.0.
• Rename qemu and container ansible-core tox environments in the integration test matrix from dot to dash-separated version identifiers to avoid tox 4.x misinterpretation.

Documentation:

• Adjust contributing guide example tox command to use the new dash-separated qemu ansible-core environment name.

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates CI tox/tox-lsr integration to use tox-lsr 3.16.0 and renames qemu/container ansible-core tox environments from dot-separated to dash-separated version identifiers to avoid tox 4.49 misinterpreting them as Python versions.

File-Level Changes

Change	Details	Files
Rename qemu and container ansible-core tox environments to use dash-separated major-minor identifiers instead of dot-separated, aligning with tox 4.49 parsing behavior.	Update qemu matrix env names from qemu-ansible-core-X.Y to qemu-ansible-core-X-Y in the qemu-kvm-integration GitHub Actions workflow. Update container matrix env names from container-ansible-core-X.Y to container-ansible-core-X-Y in the qemu-kvm-integration GitHub Actions workflow. Adjust example tox invocation in contributing documentation to use qemu-ansible-core-2-20 instead of qemu-ansible-core-2.14, matching new naming convention.	.github/workflows/qemu-kvm-integration-tests.yml contributing.md
Upgrade tox-lsr version used in CI workflows from 3.15.0 to 3.16.0.	Change pip install lines in qemu-kvm-integration-tests workflow to install tox-lsr 3.16.0 from GitHub. Change pip install lines in ansible-lint workflow to install tox-lsr 3.16.0 from GitHub. Change pip install lines in ansible-managed-var-comment workflow to install tox-lsr 3.16.0 from GitHub. Change pip install lines in ansible-test workflow to install tox-lsr 3.16.0 from GitHub.	.github/workflows/qemu-kvm-integration-tests.yml .github/workflows/ansible-lint.yml .github/workflows/ansible-managed-var-comment.yml .github/workflows/ansible-test.yml

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've left some high level feedback:

• The example in contributing.md changes both the separator and the ansible-core version (2.14 → 2-20); consider only changing the separator (e.g. 2.14 → 2-14) or briefly clarifying why the version itself is being updated to avoid confusion for contributors.
• After renaming the matrix env values to use major-minor, double-check that all corresponding tox environments (e.g. in tox.ini or related config) use the same naming convention so that CI and local runs stay aligned.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- The example in `contributing.md` changes both the separator and the ansible-core version (`2.14` → `2-20`); consider only changing the separator (e.g. `2.14` → `2-14`) or briefly clarifying why the version itself is being updated to avoid confusion for contributors.
- After renaming the matrix `env` values to use `major-minor`, double-check that all corresponding tox environments (e.g. in `tox.ini` or related config) use the same naming convention so that CI and local runs stay aligned.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}