Skip to content

ci: Comply with Ansible partner certification checking [citest_skip]#123

Merged
richm merged 1 commit intomainfrom
ci-ansible-lint-ansible-test-matrix
Apr 8, 2026
Merged

ci: Comply with Ansible partner certification checking [citest_skip]#123
richm merged 1 commit intomainfrom
ci-ansible-lint-ansible-test-matrix

Conversation

@richm
Copy link
Copy Markdown
Contributor

@richm richm commented Apr 8, 2026

https://github.com/ansible-collections/partner-certification-checker/blob/main/README.md

Unfortunately we cannot use the checkers provided by their team because they assume
the git repo is in collection format - you cannot convert to collection format first
then point the checkers at that collection. Instead, implement our own checkers that
do the same (and more) - check with multiple versions of ansible-lint and ansible-test
to ensure we cover:

  • all supported versions of EL
  • Automation Hub gating
  • the latest versions of Ansible, including the latest milestone version

This requires the latest version of tox-lsr

Signed-off-by: Rich Megginson rmeggins@redhat.com

Summary by Sourcery

Update CI workflows to align ansible-lint and ansible-test checks with Ansible partner certification requirements and broaden version coverage via tox-lsr.

CI:

  • Run ansible-lint in CI via tox across multiple ansible-lint and ansible-core versions and Python versions using a build matrix instead of the GitHub Action.
  • Run ansible-test sanity checks in CI via tox across multiple supported ansible-core and Python versions, including a milestone build, using a build matrix.
  • Upgrade tox-lsr to version 3.18.0 across all GitHub workflows that rely on it.

https://github.com/ansible-collections/partner-certification-checker/blob/main/README.md

Unfortunately we cannot use the checkers provided by their team because they assume
the git repo is in collection format - you cannot convert to collection format first
then point the checkers at that collection.  Instead, implement our own checkers that
do the same (and more) - check with multiple versions of ansible-lint and ansible-test
to ensure we cover:

* all supported versions of EL
* Automation Hub gating
* the latest versions of Ansible, including the latest milestone version

This requires the latest version of tox-lsr

Signed-off-by: Rich Megginson <rmeggins@redhat.com>
@richm richm requested a review from spetrosi as a code owner April 8, 2026 21:59
@richm richm self-assigned this Apr 8, 2026
@sourcery-ai
Copy link
Copy Markdown

sourcery-ai Bot commented Apr 8, 2026

Reviewer's Guide

Updates CI workflows to align with Ansible partner certification expectations by running ansible-lint and ansible-test via tox-lsr across multiple Ansible/Python versions, and bumps tox-lsr to 3.18.0 everywhere.

Flow diagram for updated ansible-lint GitHub Actions job

flowchart TD
  A["Event_received\nPR_or_push"] --> B{"Title_or_commit_contains_[citest_skip]?"}
  B -- "yes" --> C["Skip_ansible-lint_job"]
  B -- "no" --> D["Start_ansible-lint_job_on_ubuntu-latest"]

  D --> E["Define_matrix_versions\n(24.x/2.16.x/3.12, 26.x/2.20.x/3.13)\nfail-fast=false"]
  E --> F["Update_pip_and_git"]
  F --> G["Install_tox_and_tox-lsr_3.18.0"]
  G --> H["Set_up_Python_with_actions_setup-python_v6\npython-version=matrix.python"]

  H --> I["Run_tox_with_envs\ncollection, ansible-lint-collection\nLSR_ANSIBLE_LINT_DEP=ansible-lint==matrix.ansible_lint\nLSR_ANSIBLE_LINT_ANSIBLE_DEP=ansible-core==matrix.ansible"]
  I --> J["ansible-lint_runs_on_collection_via_tox"]
  J --> K["Job_complete_per_matrix_entry"]
Loading

File-Level Changes

Change Details Files
Run ansible-lint via tox across multiple ansible-lint/ansible-core/Python versions instead of the ansible-lint GitHub Action.
  • Added a job matrix defining two version sets for ansible-lint, ansible-core, and Python.
  • Configured actions/setup-python to use the matrix Python version.
  • Replaced manual conversion-plus-ansible-lint-Action flow with a single tox invocation that both converts to collection format and runs the ansible-lint collection environment, parameterized with matrix-driven ansible/ansible-lint versions via environment variables.
  • Updated tox-lsr dependency from 3.17.1 to 3.18.0 in the ansible-lint workflow.
.github/workflows/ansible-lint.yml
Run ansible-test via tox across a matrix of Ansible core and Python versions matching partner certification coverage instead of the ansible-test GitHub Action.
  • Introduced a strategy matrix covering multiple ansible-test targets (including milestone) and corresponding Python versions.
  • Added actions/setup-python to use the matrix Python version.
  • Replaced the ansible-test GitHub Action with a tox command that converts to collection format and runs ansible-test environments named by Ansible version, configuring basepython per matrix entry.
  • Updated tox-lsr dependency from 3.17.1 to 3.18.0 in the ansible-test workflow.
.github/workflows/ansible-test.yml
Align remaining CI workflows with the new tox-lsr version required for certification checks.
  • Bumped tox-lsr installation from 3.17.1 to 3.18.0 in the ansible-managed-var-comment workflow.
  • Bumped tox-lsr installation from 3.17.1 to 3.18.0 in the qemu-kvm integration tests workflow.
.github/workflows/ansible-managed-var-comment.yml
.github/workflows/qemu-kvm-integration-tests.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@richm richm merged commit a04f651 into main Apr 8, 2026
12 of 14 checks passed
@richm richm deleted the ci-ansible-lint-ansible-test-matrix branch April 8, 2026 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant