ci: rollout several recent changes to CI testing#192
Merged
Conversation
* Pass in a YAML true value as `__bootc_validation: true` using
the --extra-vars option to ensure that `__bootc_validation` is
treated as a boolean and not a string value.
`-e "__bootc_validation: true"`
You can also use JSON format:
`-e '{"__bootc_validation": true}'`
but YAML is simpler in this case.
* Use tox-lsr version 3.11.1
* Ensure the citest bad comment works when the test was cancelled in
addition to the failure case.
* Update contributing.md documentation
* Update number of nodes to use in testing farm, if needed
* remove unnecessary ansible-lint skips
Signed-off-by: Rich Megginson <rmeggins@redhat.com>
Reviewer's GuideThis PR enhances CI workflows by passing the validation flag as a YAML boolean, upgrading tox-lsr to 3.11.1 across multiple jobs, extending the citest bad job to catch cancelled runs, and enriching contributing.md with local CI testing guidance. Flow diagram for citest bad job handling cancelled and failed runsflowchart TD
A["Trigger citest bad job"] --> B["Check workflow status"]
B --> C["Is workflow still running?"]
C -- Yes --> D["Wait for completion"]
C -- No --> E["Check for failure or cancelled conclusion"]
E -- Found --> F["Get RUN_ID and proceed"]
E -- Not found --> G["Exit with error"]
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey there - I've reviewed your changes - here's some feedback:
- The repeated pip install of tox-lsr@3.11.1 across multiple workflows could be consolidated into a reusable action or shared variable to avoid version drift.
- The new "Running CI Tests Locally" section in contributing.md is quite detailed—consider moving it into its own guide or separate file to keep the main document concise and focused.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The repeated pip install of tox-lsr@3.11.1 across multiple workflows could be consolidated into a reusable action or shared variable to avoid version drift.
- The new "Running CI Tests Locally" section in contributing.md is quite detailed—consider moving it into its own guide or separate file to keep the main document concise and focused.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
__bootc_validation: trueusingthe --extra-vars option to ensure that
__bootc_validationistreated as a boolean and not a string value.
-e "__bootc_validation: true"You can also use JSON format:
-e '{"__bootc_validation": true}'but YAML is simpler in this case.
Use tox-lsr version 3.11.1
Ensure the citest bad comment works when the test was cancelled in
addition to the failure case.
Update contributing.md documentation
Update number of nodes to use in testing farm, if needed
remove unnecessary ansible-lint skips
Signed-off-by: Rich Megginson rmeggins@redhat.com
Summary by Sourcery
Roll out several recent updates to the CI testing workflows and documentation.
CI:
Documentation: