ci: tox-lsr 3.16.0 - fix qemu tox test failures - rename to qemu-ansible-core-X-Y [citest_skip]

[richm]

the latest version of tox 4.49 has a strange issue - it thinks that a tox testenv
like [qemu-ansible-core-2.20] is specifying python 2.20 which conflicts with the
testenv basepython of python 3.latest. There appears to be no way to workaround this.

So, rename all of the testenvs to use major-minor instead of major.minor e.g.
[qemu-ansible-core-2-20]

Signed-off-by: Rich Megginson rmeggins@redhat.com

Summary by Sourcery

Update CI tox-lsr version and align qemu/container test environment names with the new tox naming requirements.

CI:

• Rename qemu and container tox test environment identifiers from dot-based to dash-based ansible-core version notation in GitHub Actions workflows.
• Bump tox-lsr used in all GitHub Actions workflows from version 3.15.0 to 3.16.0.

Documentation:

• Update contributing guide example to use the new qemu tox environment name format with dash-separated ansible-core versions.

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates CI tox infrastructure to use tox-lsr 3.16.0 and renames qemu/container ansible-core tox environments from dot-separated to dash-separated version identifiers to avoid tox 4.49 misinterpreting them as Python versions.

Sequence diagram for CI job installing tox-lsr 3.16.0 and running qemu env

sequenceDiagram
  actor Developer
  participant GitHub_Actions as GitHub_Actions
  participant CI_Job as CI_job
  participant Pip as pip3
  participant Tox as tox
  participant Tox_LSR as tox_lsr_3_16_0

  Developer->>GitHub_Actions: Open_pull_request
  GitHub_Actions->>CI_Job: Start_ansible-lint_or_var-comment_job
  CI_Job->>Pip: install git+https://github.com/linux-system-roles/tox-lsr@3.16.0
  Pip-->>CI_Job: tox_lsr_3_16_0_installed
  CI_Job->>Tox: run -e qemu-ansible-core-2-20
  Tox->>Tox_LSR: load_qemu_environment_definition
  Tox_LSR-->>Tox: configured_env_qemu-ansible-core-2-20
  Tox-->>CI_Job: qemu_tests_executed

Loading

File-Level Changes

Change	Details	Files
Rename qemu/container tox environment names to use dash-separated ansible-core versions instead of dot-separated ones so tox 4.49 no longer parses them as Python versions.	Adjust qemu test matrix env names in the qemu-kvm-integration-tests GitHub Actions workflow from qemu-ansible-core-X.Y to qemu-ansible-core-X-Y. Adjust container test matrix env names in the same workflow from container-ansible-core-X.Y to container-ansible-core-X-Y. Update the example tox invocation in contributing.md to use the new qemu-ansible-core-2-20 style environment name.	.github/workflows/qemu-kvm-integration-tests.yml contributing.md
Update all GitHub Actions workflows to install tox-lsr 3.16.0 instead of 3.15.0 for consistency with the renamed envs and CI tooling.	Bump tox-lsr version pin to 3.16.0 in the qemu-kvm-integration-tests workflow. Bump tox-lsr version pin to 3.16.0 in the ansible-lint workflow. Bump tox-lsr version pin to 3.16.0 in the ansible-managed-var-comment workflow. Bump tox-lsr version pin to 3.16.0 in the ansible-test workflow. Bump tox-lsr version pin to 3.16.0 in the python-unit-test workflow.	.github/workflows/qemu-kvm-integration-tests.yml .github/workflows/ansible-lint.yml .github/workflows/ansible-managed-var-comment.yml .github/workflows/ansible-test.yml .github/workflows/python-unit-test.yml

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've left some high level feedback:

• The tox-lsr version string 3.16.0 is duplicated across multiple workflow files; consider centralizing this (e.g., via a reusable workflow, action input, or a single config file) so future version bumps only need to be made in one place.
• The example in contributing.md now references qemu-ansible-core-2-20, while the CI matrix only goes up to 2-19; consider aligning the example with an actually configured environment or adding a brief note if 2-20 is intentionally only an example.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- The tox-lsr version string `3.16.0` is duplicated across multiple workflow files; consider centralizing this (e.g., via a reusable workflow, action input, or a single config file) so future version bumps only need to be made in one place.
- The example in `contributing.md` now references `qemu-ansible-core-2-20`, while the CI matrix only goes up to 2-19; consider aligning the example with an actually configured environment or adding a brief note if 2-20 is intentionally only an example.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}