fix: firewall - use runtime instead of deprecated immediate

[richm]

Cause: The parameter "immediate" has been deprecated.

Consequence: The firewall role gives an error about deprecated parameter.

Fix: Use "runtime" instead of "immediate".

Result: The firewall role does not give an error.

Signed-off-by: Rich Megginson rmeggins@redhat.com

Summary by Sourcery

Bug Fixes:

• Update firewall role to use the supported runtime parameter instead of the deprecated immediate option when configuring custom tangd ports.

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates the firewall configuration task for tangd custom port to replace the deprecated Ansible firewalld parameter immediate with runtime, preventing deprecation errors while preserving behavior for managing the firewall at runtime and permanently.

Flow diagram for updated tangd custom port firewall task

flowchart TD
  A[Start Ansible play] --> B[Evaluate nbde_server_manage_firewall]
  B -->|false| C[Skip tangd custom port firewall task]
  B -->|true| D[Call firewalld module]
  D --> E[Configure port nbde_server_port/tcp]
  E --> F[Set zone nbde_server_firewall_zone]
  F --> G[Set state enabled]
  G --> H[Set runtime true]
  H --> I[Set permanent true]
  I --> J[firewalld applies runtime and permanent rules]
  C --> K[End play]
  J --> K[End play]

Loading

File-Level Changes

Change	Details	Files
Replace deprecated firewalld parameter to avoid deprecation errors while preserving runtime+permanent firewall management semantics.	Update firewalld task argument from immediate: true to runtime: true for the tangd custom port configuration Keep state: enabled and permanent: true unchanged so both runtime and permanent configuration are applied Retain conditional execution based on `nbde_server_manage_firewall	bool` without modification

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[richm]

[citest]