refactor: use ansible.posix 2.1.X for EL7 compatibility [citest_skip]#237
Merged
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuidePins the ansible.posix collection dependency to version 2.1.0 in the Ansible collection requirements to maintain EL7 compatibility. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Consider adding a short inline comment in
collection-requirements.ymlexplaining why ansible.posix is pinned to 2.1.0 (EL7 incompatibility with 2.2.0) to give future maintainers context for the fixed version. - If feasible, you might want to use a version range (e.g.,
<2.2.0) instead of an exact pin so that you can pick up compatible patch releases without further changes while still avoiding the broken version.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider adding a short inline comment in `collection-requirements.yml` explaining why ansible.posix is pinned to 2.1.0 (EL7 incompatibility with 2.2.0) to give future maintainers context for the fixed version.
- If feasible, you might want to use a version range (e.g., `<2.2.0`) instead of an exact pin so that you can pick up compatible patch releases without further changes while still avoiding the broken version.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
richm
force-pushed
the
ansible-posix-2.1.0
branch
from
28a9027 to
ae647bc
Compare
richm
changed the title
|
Warning Rate limit exceeded
You’ve run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Comment |
richm
force-pushed
the
ansible-posix-2.1.0
branch
from
ae647bc to
9449f26
Compare
richm
changed the title
The recently released ansible.posix 2.2.0 does not work on EL7. Pin the version of ansible.posix to 2.1.X. NOTE: Even though this role might not support EL7, this update is applied to all system roles for consistency. Plus, when this role is part of the system roles collection, all roles must use the same version of ansible.posix - there is no way for a role which is part of a collection to use a different version of a dependency than the version used by the other roles. Signed-off-by: Rich Megginson <rmeggins@redhat.com>
richm
force-pushed
the
ansible-posix-2.1.0
branch
from
9449f26 to
905be5d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The recently released ansible.posix 2.2.0 does not work on EL7.
Pin the version of ansible.posix to 2.1.X.
NOTE: Even though this role might not support EL7, this update
is applied to all system roles for consistency. Plus, when this
role is part of the system roles collection, all roles must use
the same version of ansible.posix - there is no way for a role
which is part of a collection to use a different version of a
dependency than the version used by the other roles.