test: ensure integration and unit pytest work in collection mode

Refactor the common code in tests_unit.yml and the integration pytest
into a single block of code.

The tests/ directory has a library sub-directory with a symlink to the
network_connections.py module.  This was causing problems because the logic
in get_modules_and_utils_paths.yml really wants the real files and
directories, not the symlinks, and for some reason the bash `-f` test
is returning `true` for the symlink.  Instead, ensure that we do not use
the link by using `-L` to screen it out.

Also added the collection paths to the search.

Make the path arrays have unique values.

Use the `realpath` filter to see the full actual path.

Signed-off-by: Rich Megginson <rmeggins@redhat.com>

Author: richm

tests/playbooks/integration_pytest_python3.yml

@@ -30,110 +30,16 @@
   tasks:
     - name: Run Pytest tests
       block:
-        - name: Create tempdir for code to test
-          tempfile:
-            state: directory
-            prefix: lsrtest_
-          register: _rundir
-
-        - name: Get tempfile for tar
-          tempfile:
-            prefix: lsrtest_
-            suffix: ".tar"
-          register: temptar
-          delegate_to: localhost
-
-        - name: Include the task '../tasks/get_modules_and_utils_paths.yml'
-          include_tasks: ../tasks/get_modules_and_utils_paths.yml
-
-        - name: Get tests directory
-          set_fact:
-            tests_directory: "{{ lookup('first_found', params) }}"
-          vars:
-            params:
-              files:
-                - tests
-                - network
-              paths:
-                - "../.."
-
-        # TODO: using tar and copying the file is a workaround for the
-        # synchronize module that does not work in test-harness. Related issue:
-        # https://github.com/linux-system-roles/test-harness/issues/102
-        #
-        - name: Create Tar file
-          command: >
-            tar -cvf {{ temptar.path }} --exclude "*.pyc"
-                --exclude "__pycache__"
-                -C {{ tests_directory | realpath | dirname }}
-                {{ tests_directory | basename }}
-                -C {{ modules_parent_and_dir.stdout_lines[0] }}
-                {{ modules_parent_and_dir.stdout_lines[1] }}
-                -C {{ module_utils_parent_and_dir.stdout_lines[0] }}
-                {{ module_utils_parent_and_dir.stdout_lines[1] }}
-          # noqa command-instead-of-module
-          delegate_to: localhost
-          changed_when: false
-
-        - name: Copy testrepo.tar to the remote system
-          copy:
-            src: "{{ temptar.path }}"
-            dest: "{{ _rundir.path }}"
-            mode: preserve
-
-        - name: Untar testrepo.tar
-          unarchive:
-            src: "{{ _rundir.path }}/{{ temptar.path | basename }}"
-            dest: "{{ _rundir.path }}"
-            remote_src: true
-
-        - name: "Create subdirectory './ansible' under '{{ _rundir.path }}'"
-          file:
-            state: directory
-            path: "{{ _rundir.path }}/ansible"
-            mode: "0755"
-
-        - name: Move module_utils to ansible directory
-          shell: |
-            if [ -d {{ _rundir.path }}/module_utils ]; then
-              mv {{ _rundir.path }}/module_utils {{ _rundir.path }}/ansible
-            fi
-          changed_when: false
-
-        - name: Fake out python module directories, primarily for python2
-          shell: |
-            for dir in $(find {{ _rundir.path }} -type d -print); do
-              if [ ! -f "$dir/__init__.py" ]; then
-                touch "$dir/__init__.py"
-              fi
-            done
-          changed_when: false
-
-        - name: Set _lsr_python_path
-          set_fact:
-            _lsr_python_path: "{{
-                  _rundir.path ~ '/' ~
-                  modules_parent_and_dir.stdout_lines[1] ~ ':' ~ _rundir.path
-            }}"
-
-        - name: Show _lsr_python_path
-          debug:
-            msg: path {{ _lsr_python_path }}
-
-        - name: "List the files in {{ _rundir.path }}"
-          command: ls -alrtFR {{ _rundir.path }}
-          changed_when: false
+        - name: Copy python files to the remote system
+          include_tasks: ../tasks/setup_remote_pytest.yml
 
         - name: Run pytest with nm provider
           block:
             - name: Run pytest with nm
-              command: >
-                pytest-3
-                {{ _rundir.path }}/{{ tests_directory | basename }}/integration/
-                --provider=nm
-              register: playbook_run
+              command: pytest-3 {{ _rundir.path }}/integration/ --provider=nm
               environment:
                 PYTHONPATH: "{{ _lsr_python_path }}"
+              register: playbook_run
               changed_when: false
           always:
             - name: Debug stdout_lines of the running playbook with nm
@@ -149,13 +55,10 @@
                 use: "{{ (__network_is_ostree | d(false)) |
                   ternary('ansible.posix.rhel_rpm_ostree', omit) }}"
             - name: Run pytest with initscripts
-              command: >
-                pytest-3
-                {{ _rundir.path }}/{{ tests_directory | basename }}/integration/
-                --provider=initscripts
-              register: playbook_run
+              command: pytest-3 {{ _rundir.path }}/integration/ --provider=initscripts
               environment:
                 PYTHONPATH: "{{ _lsr_python_path }}"
+              register: playbook_run
               changed_when: false
           always:
             - name: Debug stdout_lines of the running playbook with initscripts