ci: get rid of integration tests - broken, unmaintained#789
Merged
richm merged 1 commit intolinux-system-roles:mainfrom May 19, 2025
Merged
ci: get rid of integration tests - broken, unmaintained#789richm merged 1 commit intolinux-system-roles:mainfrom
richm merged 1 commit intolinux-system-roles:mainfrom
Conversation
The container based integration tests are broken and unmaintained. We don't need them anymore anyway. If you want to run tests in a container, use tox-lsr. https://github.com/linux-system-roles/tox-lsr?tab=readme-ov-file#container-testing Signed-off-by: Rich Megginson <rmeggins@redhat.com>
Reviewer's GuideRemove legacy container-based integration tests and related infrastructure, cleaning up documentation and CI settings and directing users to use tox-lsr for container testing. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey @richm - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Review instructions: all looks good
- 🟢 Testing: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #789 +/- ##
==========================================
+ Coverage 43.11% 43.25% +0.13%
==========================================
Files 12 12
Lines 3124 3121 -3
==========================================
+ Hits 1347 1350 +3
+ Misses 1777 1771 -6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The container based integration tests are broken and
unmaintained. We don't need them anymore anyway.
If you want to run tests in a container, use tox-lsr.
https://github.com/linux-system-roles/tox-lsr?tab=readme-ov-file#container-testing
Signed-off-by: Rich Megginson rmeggins@redhat.com
Summary by Sourcery
Remove all container-based integration tests and related infrastructure, including documentation, Dockerfiles, scripts, and CI workflow, and direct users to use tox-lsr for container testing
CI:
Documentation:
Tests: