ci: tox-lsr 3.16.0 - fix qemu tox test failures - rename to qemu-ansible-core-X-Y [citest_skip]

[richm]

the latest version of tox 4.49 has a strange issue - it thinks that a tox testenv
like [qemu-ansible-core-2.20] is specifying python 2.20 which conflicts with the
testenv basepython of python 3.latest. There appears to be no way to workaround this.

So, rename all of the testenvs to use major-minor instead of major.minor e.g.
[qemu-ansible-core-2-20]

Signed-off-by: Rich Megginson rmeggins@redhat.com

Summary by Sourcery

Update CI tox-lsr usage and qemu/container tox environment naming to remain compatible with newer tox versions.

CI:

• Rename qemu and container ansible-core tox environments from dot-based to dash-based version identifiers across GitHub workflows.
• Bump tox-lsr version used in all CI workflows from 3.15.0 to 3.16.0.

Documentation:

• Update contributing guide tox example to use the new qemu ansible-core tox environment name and version.

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates CI tox-lsr version to 3.16.0 and renames qemu/container tox environments from dot-based to dash-based ansible-core version naming to avoid tox 4.49 interpreting the env name as a Python version, plus refreshes the contributor docs example command accordingly.

Flow diagram for tox env name change to avoid Python version conflict

flowchart TD
    A[Start tox run<br>tox -e qemu-ansible-core-2-20] --> B[tox 4.49 parses env name]
    B --> C{Env name contains dot major.minor?}

    C -- Yes (old name qemu-ansible-core-2.20) --> D[tox interprets as python 2.20]
    D --> E[Conflicts with basepython python3]
    E --> F[Env resolution error]

    C -- No (new name qemu-ansible-core-2-20) --> G[tox treats name as plain env identifier]
    G --> H[Uses configured basepython python3]
    H --> I[Env created and tests executed successfully]

Loading

File-Level Changes

Change	Details	Files
Rename tox qemu/container test environment identifiers from dot-separated to dash-separated ansible-core versions and keep CI matrix consistent.	Update qemu tox env names in the qemu-kvm integration workflow matrix from patterns like qemu-ansible-core-2.16 to qemu-ansible-core-2-16 Update container tox env names in the same workflow matrix from patterns like container-ansible-core-2.16 to container-ansible-core-2-16, including commented-out scenarios	.github/workflows/qemu-kvm-integration-tests.yml
Bump tox-lsr dependency used in GitHub Actions from 3.15.0 to 3.16.0.	Update tox-lsr version in qemu-kvm integration workflow installation step Update tox-lsr version in ansible-lint workflow Update tox-lsr version in ansible-managed-var-comment workflow Update tox-lsr version in ansible-test workflow Update tox-lsr version in python-unit-test workflow	.github/workflows/qemu-kvm-integration-tests.yml .github/workflows/ansible-lint.yml .github/workflows/ansible-managed-var-comment.yml .github/workflows/ansible-test.yml .github/workflows/python-unit-test.yml
Align contributor documentation with new tox environment naming scheme for qemu tests.	Replace example tox env name in contributing guide from qemu-ansible-core-2.14 to qemu-ansible-core-2-20 to use dash-separated versioning	contributing.md

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've left some high level feedback:

• The example in contributing.md now uses qemu-ansible-core-2-20, which doesn’t match any of the environments configured in the GitHub workflows (2-16, 2-17, 2-18, 2-19); consider updating the example to use one of the actual env names or adding the corresponding env definition so they stay in sync.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- The example in `contributing.md` now uses `qemu-ansible-core-2-20`, which doesn’t match any of the environments configured in the GitHub workflows (2-16, 2-17, 2-18, 2-19); consider updating the example to use one of the actual env names or adding the corresponding env definition so they stay in sync.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}