ci: tox-lsr 3.17.0 - container test improvements, use ansible 2.20 for fedora 43 [citest_skip]

[richm]

tox-lsr 3.17.0 has some container test improvements - better output, faster runs

Use Ansible 2.20 for qemu/container tests on fedora 43

Signed-off-by: Rich Megginson rmeggins@redhat.com

Summary by Sourcery

Update CI workflows to use newer tooling and improve container test behavior.

CI:

• Bump tox-lsr used in GitHub workflows from 3.16.0 to 3.17.0.
• Switch Fedora 43 qemu and container scenarios to use Ansible Core 2.20 environments.
• Adjust container test workflow to control requirements and callback plugin setup per test run for faster subsequent executions.

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates GitHub Actions CI workflows to use tox-lsr 3.17.0 and Ansible 2.20 for Fedora 43-based qemu/container tests, and adjusts container test loop env flags to leverage new tox-lsr behavior for faster runs and better output.

Sequence diagram for GitHub Actions workflow using tox_lsr_3_17_0

sequenceDiagram
  actor Developer
  participant GitHub as GitHub_Actions
  participant Runner as CI_Runner
  participant Pip as Pip_Installer
  participant ToxLSR as tox_lsr_3_17_0
  participant Ansible as Ansible_2_20
  participant Env as Fedora_43_Container_Qemu

  Developer->>GitHub: Push_changes_or_open_PR
  GitHub->>Runner: Trigger_workflow

  Runner->>Pip: pip3_install_git_https_github_com_linux_system_roles_tox_lsr_3_17_0
  Pip-->>Runner: tox_lsr_3_17_0_installed

  Runner->>ToxLSR: Invoke_tox_lsr_for_tests
  ToxLSR->>Env: Start_container_qemu_environment
  ToxLSR->>Ansible: Use_Ansible_2_20_for_tests
  Ansible->>Env: Execute_playbooks_and_roles

  Env-->>ToxLSR: Test_results_with_improved_output
  ToxLSR-->>Runner: Aggregated_results_faster_runs
  Runner-->>GitHub: Publish_CI_status_and_logs

Loading

File-Level Changes

Change	Details	Files
Bump Ansible version to 2.20 for Fedora 43 qemu and container test scenarios.	Update qemu Fedora 43 matrix entry to use qemu-ansible-core-2-20 environment. Update container Fedora 43 and Fedora 43 bootc matrix entries to use container-ansible-core-2-20 environment.	.github/workflows/qemu-kvm-integration-tests.yml
Upgrade tox-lsr dependency used in CI workflows to version 3.17.0.	Change pip install in qemu-kvm-integration-tests workflow to use tox-lsr@3.17.0. Change pip install in ansible-lint workflow to use tox-lsr@3.17.0. Change pip install in ansible-managed-var-comment workflow to use tox-lsr@3.17.0. Change pip install in ansible-test workflow to use tox-lsr@3.17.0. Change pip install in python-unit-test workflow to use tox-lsr@3.17.0.	.github/workflows/qemu-kvm-integration-tests.yml .github/workflows/ansible-lint.yml .github/workflows/ansible-managed-var-comment.yml .github/workflows/ansible-test.yml .github/workflows/python-unit-test.yml
Adjust container test loop environment flags to align with new tox-lsr behavior and optimize subsequent runs.	Remove overrides that disabled container profile/pretty output flags. Ensure SKIP_REQUIREMENTS and SKIP_CALLBACK_PLUGINS are false for the first test run in the loop. Set SKIP_REQUIREMENTS and SKIP_CALLBACK_PLUGINS to true after each test iteration to speed up subsequent runs while preserving logs and exit codes.	.github/workflows/qemu-kvm-integration-tests.yml

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've left some high level feedback:

• Consider defining the tox-lsr version (3.17.0) in a single reusable place (e.g., a workflow env var or a composite action) so future bumps don't require touching multiple workflows in parallel.
• In the container test loop, SKIP_REQUIREMENTS and SKIP_CALLBACK_PLUGINS are only flipped from false to true; if you ever add multiple loops or reuse this snippet, it might be safer to explicitly reset them before each loop or document that the first test in the job is the only one that runs with them disabled.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- Consider defining the tox-lsr version (3.17.0) in a single reusable place (e.g., a workflow env var or a composite action) so future bumps don't require touching multiple workflows in parallel.
- In the container test loop, `SKIP_REQUIREMENTS` and `SKIP_CALLBACK_PLUGINS` are only flipped from false to true; if you ever add multiple loops or reuse this snippet, it might be safer to explicitly reset them before each loop or document that the first test in the job is the only one that runs with them disabled.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}