Skip to content

test: comment out NFS mounts from /etc/fstab for bootable test failures#168

Merged
richm merged 1 commit into
linux-system-roles:mainfrom
richm:test-remove-nfs-from-etc-fstab
Apr 29, 2026
Merged

test: comment out NFS mounts from /etc/fstab for bootable test failures#168
richm merged 1 commit into
linux-system-roles:mainfrom
richm:test-remove-nfs-from-etc-fstab

Conversation

@richm

@richm richm commented Apr 29, 2026

Copy link
Copy Markdown
Contributor

Due to snapshotmanager/snapm#955 and due to the NFS
mounts on our test machines, the bootable tests are failing. Comment out
the NFS mounts from /etc/fstab.

Signed-off-by: Rich Megginson rmeggins@redhat.com

Summary by Sourcery

Temporarily disable NFS entries in /etc/fstab during tests to prevent bootable test failures and restore them afterward.

New Features:

  • Capture and expose original uncommented NFS /etc/fstab lines as a test fact for later restoration.

Enhancements:

  • Extend test setup to detect and comment out active NFS and NFS4 fstab entries before running tests.
  • Extend test cleanup to restore previously commented NFS fstab entries to their original state.

Due to snapshotmanager/snapm#955 and due to the NFS
mounts on our test machines, the bootable tests are failing.  Comment out
the NFS mounts from /etc/fstab.

Signed-off-by: Rich Megginson <rmeggins@redhat.com>
@richm richm requested a review from spetrosi as a code owner April 29, 2026 15:41
@sourcery-ai

sourcery-ai Bot commented Apr 29, 2026

Copy link
Copy Markdown

Reviewer's Guide

This PR updates the test setup and cleanup Ansible tasks to temporarily comment out active NFS entries in /etc/fstab during bootable tests and restore them afterward, preventing NFS-related boot failures on test machines.

File-Level Changes

Change Details Files
Temporarily comment out NFS entries in /etc/fstab during tests and restore them in cleanup to avoid NFS-related boot failures.
  • Extend setup task facts to include a snapshot_fstab_nfs_lines variable to track original uncommented NFS fstab lines.
  • Scan /etc/fstab for uncommented NFS/nfs4 entries, store them in snapshot_fstab_nfs_lines, and generate a temporary fstab with those lines commented out using awk.
  • Overwrite /etc/fstab during setup with the computed version that has NFS lines commented while preserving file permissions and ownership.
  • Add cleanup logic that loops over snapshot_fstab_nfs_lines and uses a replace task to uncomment the corresponding lines in /etc/fstab, guarded by a length check to avoid running when no NFS lines were modified.
tests/tasks/setup.yml
tests/tasks/cleanup.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@richm

richm commented Apr 29, 2026

Copy link
Copy Markdown
Contributor Author

[citest]

@trgill

trgill commented Apr 29, 2026

Copy link
Copy Markdown
Collaborator

looks good

@richm richm merged commit 5ad44ae into linux-system-roles:main Apr 29, 2026
45 checks passed
@richm richm deleted the test-remove-nfs-from-etc-fstab branch April 29, 2026 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants