refactor: use ansible.posix 2.1.X for EL7 compatibility [citest_skip]#174
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuidePins the ansible.posix collection dependency to version 2.1.0 for EL7 compatibility by updating the collection requirements metadata. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Since this version pin is specifically to work around an EL7 incompatibility, consider adding a brief inline comment in
collection-requirements.ymlexplaining whyansible.posixis locked to 2.1.0 so future updates don’t inadvertently reintroduce the EL7 issue.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Since this version pin is specifically to work around an EL7 incompatibility, consider adding a brief inline comment in `collection-requirements.yml` explaining why `ansible.posix` is locked to 2.1.0 so future updates don’t inadvertently reintroduce the EL7 issue.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
ce9f5b5 to
f50e079
Compare
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe pull request adds an explicit version constraint for the ChangesAnsible Collection Dependency
🚥 Pre-merge checks | ✅ 4 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
f50e079 to
3ae184f
Compare
The recently released ansible.posix 2.2.0 does not work on EL7. Pin the version of ansible.posix to 2.1.X. NOTE: Even though this role might not support EL7, this update is applied to all system roles for consistency. Plus, when this role is part of the system roles collection, all roles must use the same version of ansible.posix - there is no way for a role which is part of a collection to use a different version of a dependency than the version used by the other roles. Signed-off-by: Rich Megginson <rmeggins@redhat.com>
3ae184f to
34d1e05
Compare
The recently released ansible.posix 2.2.0 does not work on EL7.
Pin the version of ansible.posix to 2.1.X.
NOTE: Even though this role might not support EL7, this update
is applied to all system roles for consistency. Plus, when this
role is part of the system roles collection, all roles must use
the same version of ansible.posix - there is no way for a role
which is part of a collection to use a different version of a
dependency than the version used by the other roles.
Summary by CodeRabbit
ansible.posixcollection version constraint to'>=2.1.0,<2.2.0'in the collection requirements configuration.