Skip to content

refactor: use ansible.posix 2.1.X for EL7 compatibility [citest_skip]#174

Merged
richm merged 1 commit into
mainfrom
ansible-posix-2.1.0
May 20, 2026
Merged

refactor: use ansible.posix 2.1.X for EL7 compatibility [citest_skip]#174
richm merged 1 commit into
mainfrom
ansible-posix-2.1.0

Conversation

@richm

@richm richm commented May 18, 2026

Copy link
Copy Markdown
Contributor

The recently released ansible.posix 2.2.0 does not work on EL7.
Pin the version of ansible.posix to 2.1.X.

NOTE: Even though this role might not support EL7, this update
is applied to all system roles for consistency. Plus, when this
role is part of the system roles collection, all roles must use
the same version of ansible.posix - there is no way for a role
which is part of a collection to use a different version of a
dependency than the version used by the other roles.

Summary by CodeRabbit

  • Chores
    • Updated the ansible.posix collection version constraint to '>=2.1.0,<2.2.0' in the collection requirements configuration.

Review Change Stack

@richm richm requested a review from spetrosi as a code owner May 18, 2026 21:23
@richm richm self-assigned this May 18, 2026
@sourcery-ai

sourcery-ai Bot commented May 18, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Pins the ansible.posix collection dependency to version 2.1.0 for EL7 compatibility by updating the collection requirements metadata.

File-Level Changes

Change Details Files
Pin the ansible.posix collection dependency to a specific version compatible with EL7.
  • Update collection requirements metadata to specify ansible.posix version 2.1.0
  • Ensure Ansible uses ansible.posix 2.1.0 instead of the latest (2.2.0) to avoid EL7 incompatibility issues
meta/collection-requirements.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • Since this version pin is specifically to work around an EL7 incompatibility, consider adding a brief inline comment in collection-requirements.yml explaining why ansible.posix is locked to 2.1.0 so future updates don’t inadvertently reintroduce the EL7 issue.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Since this version pin is specifically to work around an EL7 incompatibility, consider adding a brief inline comment in `collection-requirements.yml` explaining why `ansible.posix` is locked to 2.1.0 so future updates don’t inadvertently reintroduce the EL7 issue.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@richm richm force-pushed the ansible-posix-2.1.0 branch from ce9f5b5 to f50e079 Compare May 19, 2026 13:58
@richm richm changed the title refactor: use ansible.posix 2.1.0 for EL7 compatability refactor: use ansible.posix 2.1.X for EL7 compatibility May 19, 2026
@coderabbitai

coderabbitai Bot commented May 19, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: cdfccca4-4e0b-4443-a8bb-ff2e3af5683e

📥 Commits

Reviewing files that changed from the base of the PR and between eff9709 and 34d1e05.

📒 Files selected for processing (1)
  • meta/collection-requirements.yml

📝 Walkthrough

Walkthrough

The pull request adds an explicit version constraint for the ansible.posix Ansible collection in the collection requirements manifest. The constraint '>=2.1.0,<2.2.0' restricts the collection to the 2.1.x release series, preventing accidental upgrades to incompatible versions.

Changes

Ansible Collection Dependency

Layer / File(s) Summary
ansible.posix version constraint
meta/collection-requirements.yml
The ansible.posix collection requirement now includes an explicit version field restricting acceptable versions to >=2.1.0,<2.2.0.
🚥 Pre-merge checks | ✅ 4 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Description Format ⚠️ Warning PR description lacks required template format with Enhancement/Feature, Reason, and Result headers as defined in .github/pull_request_template.md. Rewrite PR description following template: Enhancement section (what changed), Reason section (why needed), Result section (impact).
Description check ❓ Inconclusive The PR description explains the reason (ansible.posix 2.2.0 incompatibility with EL7) and the result (pinning to 2.1.X), but does not follow the required template structure with explicit 'Enhancement', 'Reason', 'Result', and 'Issue Tracker Tickets' sections. Restructure the description to match the repository template: add 'Enhancement:', 'Reason:', 'Result:', and 'Issue Tracker Tickets:' section headings for clarity and consistency.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The PR title follows the Conventional Commits format with 'refactor' type and clearly describes the main change: pinning ansible.posix to 2.1.X for EL7 compatibility.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Comment @coderabbitai help to get the list of available commands and usage tips.

@richm richm force-pushed the ansible-posix-2.1.0 branch from f50e079 to 3ae184f Compare May 19, 2026 15:48
@richm richm changed the title refactor: use ansible.posix 2.1.X for EL7 compatibility refactor: use ansible.posix 2.1.X for EL7 compatibility [citest_skip] May 20, 2026
The recently released ansible.posix 2.2.0 does not work on EL7.
Pin the version of ansible.posix to 2.1.X.

NOTE: Even though this role might not support EL7, this update
is applied to all system roles for consistency.  Plus, when this
role is part of the system roles collection, all roles must use
the same version of ansible.posix - there is no way for a role
which is part of a collection to use a different version of a
dependency than the version used by the other roles.

Signed-off-by: Rich Megginson <rmeggins@redhat.com>
@richm richm force-pushed the ansible-posix-2.1.0 branch from 3ae184f to 34d1e05 Compare May 20, 2026 13:53
@richm richm merged commit 99dbbfd into main May 20, 2026
14 checks passed
@richm richm deleted the ansible-posix-2.1.0 branch May 20, 2026 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant