fix: Use verbosity level 3 for no_log#18
Merged
Conversation
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Reviewer's guide (collapsed on small PRs)Reviewer's GuideAdjusts Ansible task logging so that service_facts output is only shown at verbosity level -vvv or higher, aligning no_log behavior with the desired verbosity threshold. Flow diagram for Ansible no_log behavior based on verbosityflowchart TD
Start[Start Ansible task service_facts] --> CheckVerbosity[Check ansible_verbosity]
CheckVerbosity -->|ansible_verbosity < 3| NoLogEnabled[Set no_log to true<br/>Hide service_facts output]
CheckVerbosity -->|ansible_verbosity >= 3| NoLogDisabled[Set no_log to false<br/>Show service_facts output]
NoLogEnabled --> End[Task completes]
NoLogDisabled --> End
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Since the same
no_log: "{{ ansible_verbosity < 3 }}"logic is now used in multiple tasks, consider extracting this condition into a single variable (e.g.no_log_service_facts) to keep the threshold consistent and easier to adjust in the future.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Since the same `no_log: "{{ ansible_verbosity < 3 }}"` logic is now used in multiple tasks, consider extracting this condition into a single variable (e.g. `no_log_service_facts`) to keep the threshold consistent and easier to adjust in the future.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
ansible_verbosity < 3instead of< 2to show output with-vvvor higher.Summary by Sourcery
Enhancements: