Skip to content

fix: Use verbosity level 3 for no_log#18

Merged
spetrosi merged 1 commit into
linux-system-roles:mainfrom
spetrosi:fix-verbosity-level
May 11, 2026
Merged

fix: Use verbosity level 3 for no_log#18
spetrosi merged 1 commit into
linux-system-roles:mainfrom
spetrosi:fix-verbosity-level

Conversation

@spetrosi

@spetrosi spetrosi commented May 11, 2026

Copy link
Copy Markdown
Contributor

Use ansible_verbosity < 3 instead of < 2 to show output with -vvv or higher.

Summary by Sourcery

Enhancements:

  • Update secret registration server and trustee quadlet service_facts tasks to log details only when Ansible verbosity is at least 3.

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
@spetrosi spetrosi requested a review from richm as a code owner May 11, 2026 11:09
@sourcery-ai

sourcery-ai Bot commented May 11, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Adjusts Ansible task logging so that service_facts output is only shown at verbosity level -vvv or higher, aligning no_log behavior with the desired verbosity threshold.

Flow diagram for Ansible no_log behavior based on verbosity

flowchart TD
    Start[Start Ansible task service_facts] --> CheckVerbosity[Check ansible_verbosity]

    CheckVerbosity -->|ansible_verbosity < 3| NoLogEnabled[Set no_log to true<br/>Hide service_facts output]
    CheckVerbosity -->|ansible_verbosity >= 3| NoLogDisabled[Set no_log to false<br/>Show service_facts output]

    NoLogEnabled --> End[Task completes]
    NoLogDisabled --> End
Loading

File-Level Changes

Change Details Files
Relax no_log threshold for service_facts tasks so output is visible from -vvv upwards instead of -vv.
  • Update no_log condition to use ansible_verbosity < 3 for service_facts in secret_registration_server tasks.
  • Update no_log condition to use ansible_verbosity < 3 for service_facts in trustee_quadlet tasks.
tasks/secret_registration_server.yml
tasks/trustee_quadlet.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • Since the same no_log: "{{ ansible_verbosity < 3 }}" logic is now used in multiple tasks, consider extracting this condition into a single variable (e.g. no_log_service_facts) to keep the threshold consistent and easier to adjust in the future.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Since the same `no_log: "{{ ansible_verbosity < 3 }}"` logic is now used in multiple tasks, consider extracting this condition into a single variable (e.g. `no_log_service_facts`) to keep the threshold consistent and easier to adjust in the future.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@spetrosi spetrosi merged commit b6ca649 into linux-system-roles:main May 11, 2026
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant