Skip to content

ci: update header for run_role_with_clear_facts [citest_skip]#8

Closed
richm wants to merge 1 commit into
mainfrom
ci-update-run_role
Closed

ci: update header for run_role_with_clear_facts [citest_skip]#8
richm wants to merge 1 commit into
mainfrom
ci-update-run_role

Conversation

@richm

@richm richm commented Apr 8, 2026

Copy link
Copy Markdown
Contributor

Update header for run_role_with_clear_facts to indicate not editable
and clarify what it does

Signed-off-by: Rich Megginson rmeggins@redhat.com

Summary by Sourcery

Align role naming and testing helpers with the trustee_server role and add a reusable task file for running the role with cleared facts in tests.

Enhancements:

  • Standardize documentation, issue links, and CI badge URLs to use the trustee_server repository name.
  • Update CI test plan configuration and Testing Farm filters to reference trustee_server instead of trustee_attestation_server.

Tests:

  • Rename distro helper variables used in tests to the trustee_server prefix and update related conditionals.
  • Introduce a managed run_role_with_clear_facts test task file to clear facts and run the trustee_server role with optional failure handling.

Update header for run_role_with_clear_facts to indicate not editable
and clarify what it does

Signed-off-by: Rich Megginson <rmeggins@redhat.com>
@richm richm requested a review from spetrosi as a code owner April 8, 2026 13:31
@richm richm self-assigned this Apr 8, 2026
@sourcery-ai

sourcery-ai Bot commented Apr 8, 2026

Copy link
Copy Markdown

Reviewer's Guide

This PR renames remaining references from trustee_attestation_server to trustee_server across docs, CI/tmt configuration, and test vars, and adds a centrally managed Ansible task helper to run the role with cleared facts and configurable failure handling.

File-Level Changes

Change Details Files
Update project name and GitHub URLs from trustee_attestation_server to trustee_server in documentation and README badges.
  • Change main contributing header to reference trustee_server role name.
  • Update issue tracker and help-wanted links to the trustee_server GitHub repository.
  • Adjust CI/testing documentation to point to the trustee_server workflow files and example git URLs.
  • Update README CI badge image and link URLs to the trustee_server repository.
contributing.md
plans/README-plans.md
README.md
Rename Red Hat distro test variables to match the trustee_server role naming convention.
  • Rename role-specific RH distro list variable and its Fedora-extended variant to use _trustee_server* prefix.
  • Update conditional helper variables that check for RH/Fedora distros to reference the renamed lists.
tests/vars/rh_distros_vars.yml
Add a reusable test task file that clears Ansible facts and runs the linux-system-roles.trustee_server role with optional failure suppression.
  • Introduce tests/tasks/run_role_with_clear_facts.yml managed by linux-system-roles/.github with a non-editable header.
  • Implement a task to clear facts via meta: clear_facts before running the role.
  • Provide a conditional block to run the role with include_role when __sr_failed_when is false, catching and suppressing failures with a debug message.
  • Add a normal include_role invocation for the role when __sr_failed_when is true or undefined, parameterized by __sr_tasks_from and __sr_public.
tests/tasks/run_role_with_clear_facts.yml
Align CI/tmt configuration with the trustee_server role identifier.
  • Update Testing Farm tmt_plan_filter tag from trustee_attestation_server to trustee_server to select the correct plans.
.github/workflows/tft.yml
plans/test_playbooks_parallel.fmf

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@richm richm closed this Apr 8, 2026
@richm richm deleted the ci-update-run_role branch April 8, 2026 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant